Doc #74417 [Asn]: long2ip() is documented to accept a string, but TypeError thrown with strings

Edit report at https://bugs.php.net/bug.php?id=74417&edit=1 ID: 74417 Updated by: laruence@php.net Reported by: vedad at kajtaz dot net Summary: long2ip() is documented to accept a string, but TypeError thrown with strings Status: Assigned Type: Documentation Problem Package: Documentation problem Operating System: FreeBSD 11.0 PHP Version: 7.1.3 Assigned To: laruence Block user comment: N Private report: N New Comment: I got one 32bit box, and : var_dump(ip2long("192.168.29.10")); output: int(-1062724342) and : var_dump(long2ip((-1062724342))); output the correct value.. so in my opinion I don't think we should revert the fix here. Previous Comments: ------------------------------------------------------------------------ [2017-08-12 02:10:30] ajf@php.net This can be worked around: $ sapi/cli/php -r "declare(strict_types=1); var_dump(long2ip((int)'2130706433'));" string(9) "127.0.0.1" ------------------------------------------------------------------------ [2017-08-12 01:57:01] laruence@php.net I don't have 32bit env , just one question what does ip2long behavior in this case? ie: var_dump(ip2long("192.168.0.1")); ------------------------------------------------------------------------ [2017-04-24 08:43:47] indan at nul dot nu They changed the signature of long2ip(), but didn't update the documentation. This applies to all platforms. The original bug report proposes to fix the documentation to match the implementation. I propose to revert the change and keep the documentation as it is, because the change breaks old code on 32-bit PHP. However confusing the function name is, it always has been like this. If the change is not reverted, please also update the migration guide and add this backward incompatible change to the list. Work around for 32-bit PHP code: function string2ip($s) { if ($s > PHP_INT_MAX) $s = 2 * PHP_INT_MIN + $s; return long2ip($s); } ------------------------------------------------------------------------ [2017-04-21 14:57:59] vedad at kajtaz dot net Note that the original bug report is based on a 64bit FreeBSD build. ------------------------------------------------------------------------ [2017-04-21 08:18:01] indan at nul dot nu The problem is that IP addresses in the high range (e.g. "192.168.0.1") result in a positive number which does not fit in an INT32_MAX. I don't see how this can be solved without added unsigned support to PHP, so I think the commit changing the argument from a string to an integer should be reverted. Test code: <?php declare(strict_types=0); error_reporting(E_ALL); $n = (int)"3232242954"; // Will be truncated to INT32_MAX echo "192.168.29.10 = " . gettype($n) . " = $n\n"; echo "Test 1: '" . long2ip($n) . "'\n"; echo "Test 2: '" . long2ip("3232242954") . "'\n"; echo "Test 3: '" . long2ip("173632452") . "'\n"; /* Result: 192.168.29.10 = integer = 2147483647 Test 1: '127.255.255.255' PHP Warning: long2ip() expects parameter 1 to be integer, string given in t.php on line 7 Warning: long2ip() expects parameter 1 to be integer, string given in t.php on line 7 Test 2: '' Test 3: '10.89.107.196' */ ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=74417 -- Edit this bug report at https://bugs.php.net/bug.php?id=74417&edit=1