Bug #55197 [Opn]: required validation

Edit report at https://bugs.php.net/bug.php?id=55197&edit=1 ID: 55197 Updated by: cmb@php.net Reported by: philip@php.net Summary: required validation Status: Open Type: Bug Package: Online Doc Editor problem Operating System: Irrelevant PHP Version: Irrelevant Block user comment: N Private report: N New Comment: > People are creating invalid patches, which are patches that break the build. > Then, people commit them without first running configure.php In my opinion, a failing build is less severe than anybody committing nonsense (e.g. wrong information, gibberish) which successfully builds. And if a build fails, it might be sufficient to point the committer to <http://doc.php.net/tutorial/editing.php>, particularly the section "Validating your changes". Previous Comments: ------------------------------------------------------------------------ [2011-07-16 09:34:18] philip@php.net I don't think we need another machine doing that. The edit.php.net machine checks builds for each translation and sends emails daily when a build is broken, but there appears to be a bug that is preventing or interfering with that now. However, the intent of this bug report (feature request?) is to prevent the broken build in the first place. ------------------------------------------------------------------------ [2011-07-14 05:46:49] rquadling@php.net http://oti1.php.net/logs and http://oti1.php.net/logs/build.chms.log shows the current log files. ------------------------------------------------------------------------ [2011-07-14 05:45:49] rquadling@php.net Just to add a little weight to this, and specifically for translators, of the 10 translations, currently 5 have failed to pass configure.php. So no new Windows CHMs this week. Would a "continuous integration" mechanism be suitable. As I understand things, all of the PhD outputs can be built on Windows, and as Windows is required for the CHM and EnhancedCHM builds, it would seem suitable to do it all on one machine. Would constantly building, or at least daily building, with emailed reports for failures only (though no news is assumed to be good news - so maybe report every build) be a viable solution? I was thinking something along the lines of http://windows.php.net/downloads/snaps/php-trunk/ but for phpdoc. ------------------------------------------------------------------------ [2011-07-13 01:14:17] philip@php.net Description: ------------ Problem: People are creating invalid patches, which are patches that break the build. Then, people commit them without first running configure.php Solution (concept): Be sure people validate patches before making the commit Solution (ideas): Require configure.php to be ran before _any_ commit is made. Either do this immediately before commit, OR, allow it to be done while creating the patch and track it. Example "Patch FOO (last validated on 1/1/11)" or similar. That gets complicated as it requires tracking edits, so doing it before commit may be best. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55197&edit=1