Doc #74926 [Ver->Nab]: jddayofweek should mention it's about Julian days

Edit report at https://bugs.php.net/bug.php?id=74926&edit=1 ID: 74926 Updated by: vrana@php.net Reported by: steve at steverumberg dot com Summary: jddayofweek should mention it's about Julian days -Status: Verified +Status: Not a bug Type: Documentation Problem Package: Date/time related Operating System: Linux PHP Version: Irrelevant Block user comment: N Private report: N New Comment: It seems clear. Previous Comments: ------------------------------------------------------------------------ [2017-07-14 19:25:37] requinix@php.net Er, no. The function tells you the day number ($mode=0), day name ($mode=1), or abbreviated day name ($mode=2) for a given Julian day ($julianday). https://en.wikipedia.org/wiki/Julian_day Julian day 1 was a few thousand years ago, which PHP calculates to be a Tuesday. Of course that predates recorded history, not to mention happened way before the 7-day week was invented by the Romans, which itself was more than a millennium before the Gregorian calendar was created during the early modern period (and don't get me started on its actual adoption timeline spanning the subsequent few centuries), so whether the day was truly a "Tuesday" is pointlessly debatable... *ahem* So the function is working correctly. The docs do a decent job of hinting that this function is about Julian days, but actually stating that is certainly not out of the question. Meanwhile the docs for the other jd* functions look fine to me. ------------------------------------------------------------------------ [2017-07-14 18:51:21] steve at steverumberg dot com Description: ------------ On this page: http://php.net/manual/en/function.jddayofweek.php in the explanation of "Parameters" it says: "Return the day number as an int (0=Sunday, 1=Monday, etc)" I read this as "1" represents "Monday" When I use the numeral 1 in the function, I don't get MONDAY, I get TUESDAY. (Though I'm using an older version [PHP 5.3 on Godaddy shared server], the doc does not indicate any changes based on the version.) Thank you Test script: --------------- echo jddayofweek(1, 1); Expected result: ---------------- MONDAY Actual result: -------------- TUESDAY ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=74926&edit=1