Doc #76117 [Fbk->Asn]: uopz flags is NOT for classes, but methods

Edit report at https://bugs.php.net/bug.php?id=76117&edit=1 ID: 76117 User updated by: Andy_Schmidt at HM-Software dot com Reported by: Andy_Schmidt at HM-Software dot com Summary: uopz flags is NOT for classes, but methods -Status: Feedback +Status: Assigned Type: Documentation Problem Package: Documentation problem Operating System: any PHP Version: 7.2.3 Assigned To: cmb Block user comment: N Private report: N New Comment: No Opcode active. I even disabled WinCache and xdebug extensions and retestet. In addition, I moved the uopz extension to be first one .ini file. Result remains: PHP Fatal error: Uncaught InvalidArgumentException: unexpected parameter combination, expected (class, function, flags) or (function, flags) Stack trace: #0 E:\Hosted Sites\wwwroot\anamera_v2\test\syntax.php(6): uopz_flags('MyClass', NULL, 0) #1 {main} To me, the message does NOT indicate that "class" does not exist, it seems to state that the parameter signature doesn't match one of the two permitted variations. This is further supported by the fact that THIS will work just fine: var_dump( uopz_flags(MyClass::class, 'mymethod', 0) ); If the problem was an absent MyClass, then the combination MyClass::mymethod would also have failed. So - as long as a method parameter is not left NULL, the uopz_flags function will work as expected. Previous Comments: ------------------------------------------------------------------------ [2018-03-20 17:43:25] cmb@php.net Thanks for testing. However, my test script works for me on Windows with PHP 5.6 with UOPZ 2.0.7 and PHP 7.1 and 7.2 with UOPZ 5.0.2, which is to be expected from looking at the relevant code[1]. The InvalidArgumentException would be thrown, though, if an yet undefined class would be passed as first parameter to uopz_flags(). Is there perhaps an issue with OPcache? Note that UOPZ should be loaded before OPcache. [1] <https://github.com/krakjoe/uopz/blob/v5.0.2/uopz.c#L530> ------------------------------------------------------------------------ [2018-03-20 15:18:17] Andy_Schmidt at HM-Software dot com Result: PHP Fatal error: Uncaught InvalidArgumentException: unexpected parameter combination, expected (class, function, flags) or (function, flags) Stack trace: #0: uopz_flags('MyClass', NULL, 0) ------------------------------------------------------------------------ [2018-03-20 12:36:37] cmb@php.net Please try: <?php final class MyClass { function mymethod() {} }; var_dump( ( new ReflectionClass( 'MyClass') )->isFinal() ); uopz_flags(MyClass::class, null, 0); var_dump( ( new ReflectionClass( 'MyClass') )->isFinal() ); This should print: bool(true) bool(false) ------------------------------------------------------------------------ [2018-03-20 04:03:49] Andy_Schmidt at HM-Software dot com Description: ------------ --- From manual page: http://www.php.net/function.uopz-flags --- The manual incorrectly states: "Get or set flags on function or class". This implies to the reader that either the flags of a standalone function, or the flags of the class itself (such as "final class {}") can be queried or manipulated. In reality with version UOPZ 5.02 one can only reference a function or a class::method! One simply cannot omit the function name (e.g., making it NULL, or '' - it can't even be '__construct') The correct text shoud read: "Get or set flags on function or class method" ... "Get or set the flags on a method or function entry at runtime" ... function The name of the function or method Test script: --------------- final class MyClass { function mymethod() {} }; var_dump( ( new ReflectionClass( 'MyClass') )->isFinal() ); if ( !defined( 'ZEND_ACC_FETCH' ) ) define( 'ZEND_ACC_FETCH', PHP_INT_MAX ); // Works: var_dump( uopz_flags( 'MyClass', 'mymethod' , ZEND_ACC_FETCH ) ); // Fails: var_dump( uopz_flags( 'MyClass', '' , ZEND_ACC_FETCH ) ); var_dump( uopz_flags( 'MyClass', NULL , ZEND_ACC_FETCH ) ); ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76117&edit=1