Doc #73655 [Opn->Csd]: Spoofchecker::isSuspicious behavior change due to upstream changes
Edit report at https://bugs.php.net/bug.php?id=73655&edit=1
ID: 73655
Updated by: ab@php.net
Reported by: sjon at hortensius dot net
Summary: Spoofchecker::isSuspicious behavior change due to
upstream changes
-Status: Open
+Status: Closed
Type: Documentation Problem
Package: intl
PHP Version: 7.1.0
-Assigned To:
+Assigned To: ab
Block user comment: N
Private report: N
New Comment:
Since there are no further comments, closing the ticket.
Thanks.
Previous Comments:
------------------------------------------------------------------------
[2017-10-20 18:32:40] ab@php.net
The behavior change should be fixed here http://git.php.net/?p=php-src.git;a=commitdiff;h=f95063647ccebfde5e8e39bc3349e63f19662395
ICU > 58 undergone significant BC breaches, more fixes might be necessary. In general, the fact a
locale were needed to have right suspicious checks was not new. Now, with the removal of the MSC and
WSC, as well as single script and lower case data removals, it becomes unavoidable. I thought about
enforcing the empty allowed locales check, but it seems a bit too much ATM. Still, this issue is
worth documenting, as there are no good ways to bring ICU to the old behavior. Neither it would make
much sense regarding the latest UNICODE security specs. Turning this into a doc issue now, further
tests on the subject are appreciated to catch possible misbehaviors with modern ICU.
Thanks.
------------------------------------------------------------------------
[2017-10-20 18:16:05] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f95063647ccebfde5e8e39bc3349e63f19662395
Log: Fixed bug #73655 Spoofchecker::isSuspicious behavior change due to upstream changes
------------------------------------------------------------------------
[2016-12-05 17:33:37] cmb@php.net
One can get around the removal of WSC and MSC by setting the list of allowed locales manually, see
<https://3v4l.org/33qXs>, for instance. So this might be
solely a documentation issue.
Stas, as you're listed as ext/intl maintainer, what do you think?
------------------------------------------------------------------------
[2016-12-05 17:12:02] cmb@php.net
Related To: Bug #73656
------------------------------------------------------------------------
[2016-12-05 16:34:30] requinix@php.net
I don't understand the terminology but it seems this was an intentional change (or at least
accepted side effect) with ICU 85.
http://bugs.icu-project.org/trac/ticket/12549
So this is tentatively NAB and in need of documentation changes, but for all I know there may be a
way to preserve the old behavior, possibly involving toggle assorted spoofchecking options if the
uspoof C API has that.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=73655
--
Edit this bug report at https://bugs.php.net/bug.php?id=73655&edit=1
Thread (4 messages)