Doc #76893 [Opn->Csd]: Typos in ".inc" files in "ext/spl/internal"

Edit report at https://bugs.php.net/bug.php?id=76893&edit=1 ID: 76893 Updated by: nikic@php.net Reported by: ejrx7753 at gmail dot com Summary: Typos in ".inc" files in "ext/spl/internal" -Status: Open +Status: Closed Type: Documentation Problem Package: SPL related Operating System: Irrelevant PHP Version: 7.3.0 -Assigned To: +Assigned To: nikic Block user comment: N Private report: N New Comment: Indeed, this issue has been "fixed" by deleting the files in master :) Previous Comments: ------------------------------------------------------------------------ [2018-09-17 02:16:21] carusogabriel@php.net We've already dropped the SPL documentation in the master branch: http://git.php.net/?p=php-src.git;a=commit;h=9003d8a4, as it was outdated, and the one at https://php.net/spl should be used instead. The links you provide were from PHP-7.3 branch, so, I believe this bug can be closed as "Won't fix". ------------------------------------------------------------------------ [2018-09-17 00:49:15] ejrx7753 at gmail dot com Additionally, "spl/internal/cachingiterator.inc" CachingIterator::__construct uses two class constants not defined: self::CIT_TOSTRING_USE_KEY and self::CIT_TOSTRING_USE_CURRENT. ------------------------------------------------------------------------ [2018-09-17 00:30:36] ejrx7753 at gmail dot com Description: ------------ Just to be clear, this is a cosmetic issue with no demonstrated harm, but there are some apparent typos in "ext/spl/internal/splobjectstorage.inc" and "ext/spl/internal/recursivecachingiterator.inc". Typos are of a few categories: - misnamed methods - extra colons - missing colons I'm not sure what these files are used for exactly, but I ran them as PHP and all of them parse file except for these 4-line exceptions. I'm sure whatever build process if any uses these .inc does not care about theses issues, but these are clearly PHP code files. Details: splobjectstorage.inc --- offsetEsists should be "offsetExists" --- missing commas at end of "current" and "getInfo" recursivecachingiterator.inc "function rewind();" is not abstract, but has a colon Git links: https://github.com/php/php-src/blob/PHP- 7.3/ext/spl/internal/splobjectstorage.inc https://github.com/php/php-src/blob/PHP-7.3/ext/spl/internal/recursivecachingiterator.inc Test script: --------------- n/a Expected result: ---------------- n/a Actual result: -------------- n/a ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76893&edit=1