Doc #77271 [Opn->Ver]: PHP 7.3: Various info missing from changelog/migration guide

Edit report at https://bugs.php.net/bug.php?id=77271&edit=1 ID: 77271 Updated by: cmb@php.net Reported by: bugs dot php dot net_nospam at adviesenzo dot nl Summary: PHP 7.3: Various info missing from changelog/migration guide -Status: Open +Status: Verified Type: Documentation Problem Package: Documentation problem PHP Version: 7.3.0 -Assigned To: +Assigned To: cmb Block user comment: N Private report: N New Comment: > The changelog for 7.3.0 […] is missing a number of changelog > entries which are included in the 7.3 changelog […] for changes > which *have* been shipped with 7.3.0. Sorry, my bad. > The way it looks to me, the documentation on the > ldap_parse_result() function page is wrong. Not the > $serverctrls parameter, but an > $out parameter has been added. Well, the name of the parameter is $serverctrls, and it is passed by reference, but only used as out parameter (i.e. it does not matter wich value you pass to the function). > The way it looks to me, the documentation on the > ldap_get_option() and the > ldap_set_option() function pages is > missing the since 7.3 for the ����� ��ְ��� > JLDAP_OPT_SERVER_CONTROLS and > LDAP_OPT_CLIENT_CONTROLS options. These options have already been supported by these functions before, but not properly, so the support has been fixed now. I'm going to reword the migration guide entry. Previous Comments: ------------------------------------------------------------------------ [2018-12-09 14:31:01] bugs dot php dot net_nospam at adviesenzo dot nl One more: Looks like the CURL_VERSION_KERBEROS5 and the CURL_VERSION_UNIX_SOCKETS constants were already introduced in PHP 7.0.7, so these are, AFAICS, *not* new to PHP 7.3. ------------------------------------------------------------------------ [2018-12-09 14:23:25] bugs dot php dot net_nospam at adviesenzo dot nl Description: ------------ I realize you all are probably still working on updating the docs for PHP 7.3, but hopefully this list of findings will help <3 * The changelog for 7.3.0 - github.com/php/php-src/blob/PHP-7.3.0/UPGRADING - is missing a number of changelog entries which are included in the 7.3 changelog - github.com/php/php-src/blob/PHP-7.3/UPGRADING - for changes which *have* been shipped with 7.3.0. Additionally, the migration guide makes no mention of the following: * New functions: - net_get_interfaces() (also missing from UPGRADING, but mentioned in NEWS and php.net/ChangeLog-7.php#7.3.0) - ldap_exop_refresh() (also missing from UPGRADING, but mentioned in NEWS and php.net/ChangeLog-7.php#7.3.0) * New constants: - FILTER_SANITIZE_ADD_SLASHES (mentioned in php.net/manual/en/migration73.other-changes.php#migration73.other-changes.filter, but not on the new constants page) - LDAP_CONTROL_ASSERT - STREAM_CRYPTO_PROTO_TLSv1_0 - STREAM_CRYPTO_PROTO_TLSv1_1 - STREAM_CRYPTO_PROTO_TLSv1_2 Other remarks: * Lightweight Directory Access Protocol: php.net/manual/en/migration73.new-features.php#migration73.new-features.ldap vs the documentation of the ldap_parse_result() function php.net/manual/en/function.ldap-parse-result.php The way it looks to me, the documentation on the ldap_parse_result() function page is wrong. Not the $serverctrls parameter, but an $out parameter has been added. This is also listed wrong in the Changelog section of the page and the parameter is also missing from the Parameters documentation for the function. * Lightweight Directory Access Protocol: php.net/manual/en/migration73.new-features.php#migration73.new-features.ldap vs the documentation of the ldap_get_option() function php.net/manual/en/function.ldap-get-option.php and the ldap_set_option() function php.net/manual/en/function.ldap-set-option.php The way it looks to me, the documentation on the ldap_get_option() and the ldap_set_option() function pages is missing the since 7.3 for the LDAP_OPT_SERVER_CONTROLS and LDAP_OPT_CLIENT_CONTROLS options. If those were previously already supported, then the entry (third bullet) in the changelog probably needs improved wording. * LDAP Constants php.net/manual/en/ldap.constants.php Looks like the new constants were added, but without a since 7.3 mention. * Continue Targeting Switch issues Warning: The second line of the error message is missing a // before it in the code sample in php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switch * FastCGI Process Manager php.net/manual/en/migration73.new-features.php#migration73.new-features.fpm Looks like the new options aren't listed yet on php.net/manual/en/install.fpm.configuration.php And just to check my own comprehension: these are just to be used in php-fpm.conf ? and cannot be accessed through ini_get() or ini_set() ? * Strip-Tags Streaming php.net/manual/en/migration73.deprecated.php#migration73.deprecated.core.strip-tags-streaming Looks like the affected functions has not been marked as deprecated yet - php.net/manual/en/function.fgetss.php (and the others). Looks like the deprecation of the string.strip_tags stream filter has not be annotated yet: php.net/manual/en/filters.string.php ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=77271&edit=1