Doc #76071 [Opn->Fbk]: function.openssl-encrypt php 5.6 code example it poor from a security standpoin

Edit report at https://bugs.php.net/bug.php?id=76071&edit=1 ID: 76071 Updated by: girgias@php.net Reported by: junk at gathond dot dk Summary: function.openssl-encrypt php 5.6 code example it poor from a security standpoin -Status: Open +Status: Feedback Type: Documentation Problem -Package: Documentation problem +Package: OpenSSL related -Operating System: ANY +Operating System: N/A PHP Version: Irrelevant Block user comment: N Private report: N New Comment: Is this still the case? Moreover, would it be possible to add a patch using the online editor, located at https://edit.php.net ? Previous Comments: ------------------------------------------------------------------------ [2018-03-09 07:36:01] junk at gathond dot dk Description: ------------ --- From manual page: http://www.php.net/function.openssl-encrypt --- The example code has a few items which if not downright security issues, at least is bad practice from a security POV. issue 1: The IV should be included in the HMAC calculation, otherwise this is left open to manipulation. issue 2: When decrypting the MAC should be verified before attempting to decrypt the contents, otherwise any timing impacts on the decryption itself may still leak information about the correctness of the guess. Because of issue 1 it would probably also be better to reorder the data in the example so it is $iv.$ciphertext_raw.$hmac instead. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76071&edit=1