Doc #77725 [Asn]: Mention of PHP 4 and Zend Engine 1 with variable references
| From: | kalle@php.net | Date: | Sat, 23 Mar 2019 20:53:54 +0000 |
| Subject: | Doc #77725 [Asn]: Mention of PHP 4 and Zend Engine 1 with variable references | ||
| References: | 1 | Groups: | php.doc.bugs |
| Request: | Send a blank email to doc-bugs+get-16506@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=77725&edit=1
ID: 77725
Updated by: kalle@php.net
Reported by: girgias@php.net
Summary: Mention of PHP 4 and Zend Engine 1 with variable
references
Status: Assigned
Type: Documentation Problem
Package: *General Issues
PHP Version: Irrelevant
-Assigned To: kalle
+Assigned To: girgias
Block user comment: N
Private report: N
New Comment:
Sorry it took so long, I reviewed the patch in the editor and it looks good, feel free to commit it,
just make sure it validates.
I tried to commit it but it said there was some update error and I'm not that familiar with the
editor interface so I cannnot tell what is going on.
Previous Comments:
------------------------------------------------------------------------
[2019-03-19 14:55:53] girgias@php.net
Ping @kalle, anytime during the week?
------------------------------------------------------------------------
[2019-03-13 14:51:15] girgias@php.net
Hey Kalle updated the patch may you have another look at it (still the same link http://edit.php.net/?patchID=3314&project=PHP)
And if you have time could you have a look at another, larger, patch that removes notions of PHP 4
and PHP 5.0.0? http://edit.php.net/?patchID=3282&project=PHP
Cheers
------------------------------------------------------------------------
[2019-03-13 09:56:28] kalle@php.net
I reviewed the patch;
The patches seems to make the assumption that arrays like $HTTP_POST_VARS is PHP4 only, This is not
the case as they were available after the introduction of superglobals like $_POST in 4.1.0 all the
way to their deprecation in 5.3.0. Check the register_long_arrays ini directive, which I removed in
5.4.0.
(Just assign me if you need more comments as I am not subscribed to bug reports)
Thanks =D
------------------------------------------------------------------------
[2019-03-11 22:55:42] girgias@php.net
Updated my patch at http://edit.php.net/?patchID=3314&project=PHP
to include the fix for this.
------------------------------------------------------------------------
[2019-03-11 22:49:27] girgias@php.net
Huh, seems reasonable to write it like that Kalle.
Will go on and update my current patch for it.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=77725
--
Edit this bug report at https://bugs.php.net/bug.php?id=77725&edit=1