Doc #79341 [Csd->Ver]: XmlWriter docs does not say $uri is nullable

Edit report at https://bugs.php.net/bug.php?id=79341&edit=1 ID: 79341 Updated by: cmb@php.net Reported by: jtojnar at gmail dot com Summary: XmlWriter docs does not say $uri is nullable -Status: Closed +Status: Verified Type: Documentation Problem Package: XML Writer PHP Version: Irrelevant -Assigned To: +Assigned To: cmb Block user comment: N Private report: N Previous Comments: ------------------------------------------------------------------------ [2020-10-30 11:26:10] phpdocbot@php.net Automatic comment on behalf of cmb Revision: http://git.php.net/?p=doc/en.git;a=commit;h=11952f8447b672c766e0bf6b6f709abe20fc1433 Log: Fix #79341: XmlWriter docs does not say $uri is nullable ------------------------------------------------------------------------ [2020-03-04 12:51:37] cmb@php.net The following pull request has been associated: Patch Name: Fix #79341: XmlWriter docs does not say $uri is nullable On GitHub: https://github.com/php/doc-en/pull/54 Patch: https://github.com/php/doc-en/pull/54.patch ------------------------------------------------------------------------ [2020-03-04 10:31:25] jtojnar at gmail dot com Description: ------------ --- From manual pages: * https://php.net/function.xmlwriter-write-attribute-ns * https://www.php.net/manual/en/function.xmlwriter-write-element-ns.php --- The URI element should be marked as nullable, see the stub: https://github.com/php/php-src/blob/c05a9c3dcd587418906d9d25f83872e027f7dd43/ext/xmlwriter/xmlwriter.stub.php#L35 Test script: --------------- <?php $writer = new XMLWriter; $writer->openMemory(); $writer->setIndent(true); $writer->startElement('foo'); $writer->writeAttribute('xmlns:example', 'https://www.example.com/'); $writer->startElementNS('example', 'meta', null); $writer->writeAttributeNS('example', 'spout', null, 'test'); $writer->endElement(); $writer->endElement(); echo $writer->outputMemory(); ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=79341&edit=1