Doc #80520 [Opn->Csd]: Uploading anonymous documentation edits
Edit report at https://bugs.php.net/bug.php?id=80520&edit=1
ID: 80520
User updated by: craig at craigfrancis dot co dot uk
Reported by: craig at craigfrancis dot co dot uk
Summary: Uploading anonymous documentation edits
-Status: Open
+Status: Closed
Type: Documentation Problem
Package: MySQLi related
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
Closed, because page has been removed
Previous Comments:
------------------------------------------------------------------------
[2020-12-16 15:26:27] craig at craigfrancis dot co dot uk
Thanks @cmb, that's really good to know.
I've created 2 PRs; the first is to use parameterised queries, the second introduces HTML and
URL encoding (considering the output is HTML).
https://github.com/php/doc-en/pull/278
https://github.com/php/doc-en/pull/279
As to the "Edit" link on the PHP documentation pages, is it worth changing this to the
GitHub repo?
As in, rather than a link to:
https://edit.php.net/?project=PHP&perm=en/mysqli.examples-basic.php
Change it to:
https://github.com/php/doc-en/blob/master/reference/mysqli/examples.xml
And hope that anyone following the link will know how to create a PR?
------------------------------------------------------------------------
[2020-12-15 18:26:42] cmb@php.net
> But how do those changes get committed, checked, and uploaded to
> the php.net website?
Someone who is fully pain resistant would need to review on
edit.php.net. Please provide future change requests as PRs
against <https://github.com/php/doc-en> where the
review process
is so much more productive.
------------------------------------------------------------------------
[2020-12-15 18:19:19] craig at craigfrancis dot co dot uk
Description:
------------
---
From manual page: https://php.net/mysqli.examples-basic
---
A week ago I edited the "MySQLi extension basic examples" page, and that seems to have
saved, as future edits mention "File modified by anonymous #1457"
But how do those changes get committed, checked, and uploaded to the php.net website?
For reference, I've changed the SQL to use parameterised queries (bind_param), as it's bad
practice to concatenate values into SQL string, and the output needs to use HTML encoding
(considering the HTML context).
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=80520&edit=1
Thread (4 messages)