Edit report at https://bugs.php.net/bug.php?id=67549&edit=1
ID: 67549
Updated by: git@php.net
Reported by: giso at connectholland dot nl
Summary: $peg argument not documented
-Status: Assigned
+Status: Closed
Type: Documentation Problem
Package: svn
PHP Version: 5.5.14
Assigned To: alan_k
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of roojs
Revision: https://github.com/php/pecl-tools-svn/commit/0537c89ab973edf0851d03249c18d8b0569f6e9d
Log: fix #67549 - remove unused peg argument
Previous Comments:
------------------------------------------------------------------------
[2021-06-07 09:41:21] cmb@php.net
Several SVN repos have been moved to Github a while ago. I just
invited you to <https://github.com/php/pecl-tools-svn>.
I'm
uncomfortable with working on that repo, because I cannot even
build on Windows.
------------------------------------------------------------------------
[2021-06-07 03:09:59] alan_k@php.net
Committing to SVN seems to not work anymore - here's the patch to fix this.
--- trunk/svn.c (revision 352318)
+++ trunk/svn.c (working copy)
@@ -961,7 +961,7 @@
}
-/* {{{ proto array svn_ls(string repository_url [, int revision [, bool recurse [, bool peg]]])
+/* {{{ proto array svn_ls(string repository_url [, int revision [, bool recurse ]])
Returns a list of a directory in a working copy or repository, optionally at revision_no. */
PHP_FUNCTION(svn_ls)
{
@@ -968,7 +968,7 @@
const char *repos_url = NULL;
const char *utf8_repos_url = NULL;
long repos_url_len;
- zend_bool recurse = 0, peg = 0;
+ zend_bool recurse = 0;
svn_error_t *err;
svn_opt_revision_t revision = { 0 };
apr_hash_t *dirents;
@@ -977,8 +977,8 @@
const char *true_path;
apr_hash_index_t *hi;
- if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|lbb",
- &repos_url, &repos_url_len, &revision.value.number, &recurse, &peg) ==
FAILURE) {
+ if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|lb",
+ &repos_url, &repos_url_len, &revision.value.number, &recurse) == FAILURE) {
return;
}
PHP_SVN_INIT_CLIENT();
------------------------------------------------------------------------
[2021-06-01 02:27:40] alan at roojs dot com
Yes,
The peg option was removed here - It's probably only in there for BC - the argument is ignored
http://svn.php.net/viewvc/pecl/svn/trunk/svn.c?r1=315262&r2=317303
------------------------------------------------------------------------
[2021-05-31 13:55:14] cmb@php.net
Alan, can you confirm that this parameter is indeed unused?
------------------------------------------------------------------------
[2018-02-24 17:16:43] cmb@php.net
From looking at the sources, the $peg parameter appears to be
unused.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=67549
--
Edit this bug report at https://bugs.php.net/bug.php?id=67549&edit=1