#49074 [Csd->Tbd]: private class static fields can be modified by using reflection

From: Date: Sat, 01 Aug 2009 21:10:18 +0000
Subject: #49074 [Csd->Tbd]: private class static fields can be modified by using reflection
References: 1  Groups: php.bugs php.doc.bugs 
Request: Send a blank email to doc-bugs+get-2590@lists.php.net to get a copy of this message
ID: 49074 Updated by: felipe@php.net Reported By: 1000235409 at smail dot shnu dot edu dot cn -Status: Closed +Status: To be documented Bug Type: Reflection related Operating System: * -PHP Version: 5.3.0 +PHP Version: 5.2, 5.3, HEAD New Comment: Complementing the fix: ReflectionClass::getStaticProperties() was changed to do not return the private properties from parent class; behavior already adopted in ReflectionClass::getDefaultProperties() and ReflectionClass::getProperties(). (PHP >= 5.2.11) Previous Comments: ------------------------------------------------------------------------ [2009-08-01 01:01:43] svn@php.net Automatic comment from SVN on behalf of jani Revision: http://svn.php.net/viewvc/?view=revision&revision=286606 Log: - Added test for bug #49074 ------------------------------------------------------------------------ [2009-08-01 00:50:26] jani@php.net This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2009-08-01 00:48:34] svn@php.net Automatic comment from SVN on behalf of jani Revision: http://svn.php.net/viewvc/?view=revision&revision=286605 Log: - Fixed bug #49074 (private class static fields can be modified by using reflection) ------------------------------------------------------------------------ [2009-07-31 23:51:33] jani@php.net Modifying returned array should not affect this. So expected output should be of course: 1 data2==>2 data3==>3 data==>1 data4==>4 ------------------------------------------------------------------------ [2009-07-27 13:08:33] 1000235409 at smail dot shnu dot edu dot cn Description: ------------ When calling ReflectionClass::getStaticProperties() with a '&' operator, we can easily modify the private static fields outside the class, but only for fields declared in the parent class, not the class itself. But I don't know if PHP should make it possible to modify the inaccessible class static fields or not, since the PHP manual just contains a prototype in Reflection. Reproduce code: --------------- class Test { private static $data = 1; private static $data4 = 4; public static function test1() { echo self::$data; } } class Test2 extends Test { private static $data2 = 2; public static $data3 = 3; } $r = new ReflectionClass('Test2'); $m = & $r->getStaticProperties(); //here, with the '&' $m['data'] = 100; //$data is in the parent class. $m['data4'] = 400; //$data4 is in the parent class. $m['data2'] = 200; //no effect. $m['data3'] = 300; //no effect. Test::test1(); echo "\n"; $m = $r->getStaticProperties(); foreach ($m as $key => $val) { echo $key . '==>' . $val . "\n"; } Expected result: ---------------- 1 data2==>2 data3==>3 data==>1 data4==>4 /**OR**/ 100 data2==>200 data3==>300 data==>100 data4==>400 Actual result: -------------- 100 data2==>2 data3==>3 data==>100 data4==>400 ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=49074&edit=1

« previous php.doc.bugs (#2590) next »