Doc #54976 [Opn]: Wrong parameter description
| From: | philip@php.net | Date: | Sat, 04 Jun 2011 02:24:56 +0000 |
| Subject: | Doc #54976 [Opn]: Wrong parameter description | ||
| References: | 1 | Groups: | php.doc.bugs |
| Request: | Send a blank email to doc-bugs+get-6694@lists.php.net to get a copy of this message | ||
Edit report at http://bugs.php.net/bug.php?id=54976&edit=1
ID: 54976
Updated by: philip@php.net
Reported by: php at sp-in dot dk
Summary: Wrong parameter description
Status: Open
Type: Documentation Problem
Package: Documentation problem
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
Assuming you only mean reverting changes to the incorrect files (which I assume is
a small proportion), then that sounds great. And if the alternate text (i.e., the
old text) is written more than 3x within the manual then creating an entity for it
is a good idea.
Previous Comments:
------------------------------------------------------------------------
[2011-06-04 04:19:37] frozenfire@php.net
Yeah, perhaps reverting all of those changes to the original text would be the
best course of action. Though, I think that using a note is preferable to the
stipulatory wording that was originally used.
------------------------------------------------------------------------
[2011-06-04 04:12:11] philip@php.net
The change was made here:
http://svn.php.net/viewvc/phpdoc/en/trunk/reference/image/functions/imagettfbbo
x.xml?r1=297028&r2=309972
But because it changed many functions:
http://svn.php.net/viewvc?view=revision&revision=309972
It may have also caused bugs elsewhere.
Another possible course of action:
- Find functions where the entity was accidentally applied
- Revert the change in those places
Thoughts?
------------------------------------------------------------------------
[2011-06-04 04:07:02] frozenfire@php.net
I added a patch for this. Any objections to committing it as-is?
------------------------------------------------------------------------
[2011-06-04 04:06:41] frozenfire@php.net
The following patch has been added/updated:
Patch Name: imagettfbox_size_param
Revision: 1307153201
URL: http://bugs.php.net/patch-display.php?bug=54976&patch=imagettfbox_size_param&revision=1307153201
------------------------------------------------------------------------
[2011-06-02 12:59:39] php at sp-in dot dk
Description:
------------
---
From manual page: http://www.php.net/function.imagettfbbox#Parameters
---
The text describing the size parameter is wrong (looks copy/pasted from another page).
Current:
size:
If you created the image from a file, only colors used in the image are resolved. Colors present
only in the palette are not resolved.
Could be? (copied from imagettftext):
The font size. Depending on your version of GD, this should be specified as the pixel size (GD1) or
point size (GD2).
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=54976&edit=1