Edit report at https://bugs.php.net/bug.php?id=60526&edit=1
ID: 60526
Updated by: yannick@php.net
Reported by: jakoch at web dot de
Summary: Defect "Download unified diff as a patch"
Status: Re-Opened
Type: Bug
Package: Online Doc Editor problem
PHP Version: Irrelevant
Assigned To: yannick
Block user comment: N
Private report: N
New Comment:
Your patch contains only new files (translated from scratch).
So, the diff isn't revelante here as we can't compare your file with an other.
For me, actually, this action don't reload the editor. It will just download an
empty patch, as expected for this "new" translated file.
The only solution here according to me is to detect the type of files into the
patch, and don't display the "view unified diff" & the download patch link when
there is only new translated file.
Previous Comments:
------------------------------------------------------------------------
[2011-12-18 14:34:22] jakoch at web dot de
Yes.
Please go to section "Patches for review".
Look for my name "Jens-André Koch".
You will find a patch called "de/install/fpm".
It's the translation from "en" to "de".
Right-click on the item, then "View unified diff".
New windows opens, presenting a link to
"http://edit.php.net/?patchID=584&project=PHP".
If one clicks this, editor will reload.
So please open the link in new tab to stay in the editor.
------------------------------------------------------------------------
[2011-12-17 20:35:50] yannick dot torres at gmail dot com
Hi,
Svn is actually uptodate.
Could you point me the patch who the downloaded diff is empty ?
Best,
Yannick
------------------------------------------------------------------------
[2011-12-17 20:19:37] jakoch at web dot de
Thanks for fixing this, Yannick!
When will the changes take effect?
I've tested the Editor minutes ago and the bug(s) is still there..
guess, pushing the svn version to live takes a while...
Regards, Jens
------------------------------------------------------------------------
[2011-12-17 14:34:54] yannick@php.net
This bug has been fixed in SVN, and should show up online in an
hour or three.
Thank you for the report, and for helping us make PHP.net better.
------------------------------------------------------------------------
[2011-12-17 14:34:12] yannick@php.net
Automatic comment from SVN on behalf of yannick
Revision: http://svn.php.net/viewvc/?view=revision&revision=321090
Log: Fix bug #60526 & #60527 : unified diff download work again
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=60526
--
Edit this bug report at https://bugs.php.net/bug.php?id=60526&edit=1