Bug #63703 [Com]: Bugmail is sent for private bug reports when changing bug type

Edit report at https://bugs.php.net/bug.php?id=63703&edit=1 ID: 63703 Comment by: tyrael@php.net Reported by: aharvey@php.net Summary: Bugmail is sent for private bug reports when changing bug type Status: Verified Type: Bug Package: Translation problem Operating System: Irrelephpant PHP Version: Irrelevant Block user comment: N Private report: N New Comment: just pasting this from our irc conversation with philip and bjori: if a bug (is private) AND (not Security bug type) AND (Documentation Problem bugtype OR it's package has a list_email address set which isn't a private address) then it will post notifications to a public list Previous Comments: ------------------------------------------------------------------------ [2012-12-06 03:43:29] tyrael@php.net here is the relevant code: http://git.php.net/? p=web/bugs.git;a=blob;f=include/functions.php;h=2a8647c74ab99db00062b9060f1ab3ff 0e2cab6a;hb=HEAD#l1058 from that you can see that the private field has nothing to do with sending or not sending notification mails. get_package_mail() has a clause which will force using the security@php.net as the default recipient list for a bug, but when you change the bug type from Security, that will not happen, and if there is a list_email set for that package in bugdb_pseudo_packages that address will be notified. I think we should change the code to not send emails to the list_emails (and the currently hard coded $docBugEmail for Documentation Problems) if the private flag is set. Apart from the security@ list there is only one package which has a non-public list_email which is PHP.net Systems Operation problem => systems@php.net. And even for that list there is no reason to bother sending an email to that email address, because many of the people on that list doesn't have trusted dev or security dev access on bugsweb, so they couldn't see the bug anyways. Would be nice if somebody could review my reasoning here before I commit it. ------------------------------------------------------------------------ [2012-12-06 01:45:27] aharvey@php.net Description: ------------ Bugmail was sent when the type of bug #62966 was changed from Security to Documentation, even though as far as I know the report has never been non-private — certainly the e-mail I received marked it as private. Archive link: http://news.php.net/php.doc.bugs/9220 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=63703&edit=1