Bug #64362 [Opn->Csd]: Reject this patch does not close modal dialog
Edit report at https://bugs.php.net/bug.php?id=64362&edit=1
ID: 64362
Updated by: yannick@php.net
Reported by: salathe@php.net
Summary: Reject this patch does not close modal dialog
-Status: Open
+Status: Closed
Type: Bug
Package: Online Doc Editor problem
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of yannick.torres@gmail.com
Revision: http://git.php.net/?p=web/doc-editor.git;a=commit;h=4e3f3b174d668ae0229d50f20bf08044de1abe96
Log: Fix bug #64362 : Modal window is now close when we choose to reject a patch in the anonymous
patch manager. We also add a confirm dialog since the action is irreversible. We also add some
pixel's height for this window to fix height issue with some UI translation.
Previous Comments:
------------------------------------------------------------------------
[2013-03-05 21:33:39] salathe@php.net
[1] http://i.imgur.com/6nVxSEP.png
------------------------------------------------------------------------
[2013-03-05 20:56:07] salathe@php.net
Description:
------------
When reviewing patches, the "Anonymous patch manager" dialog box [1] is
presented. Choosing "Reject this patch" and clicking "Next" results in the file
being rejected and rolled back successfully, but the dialog box is not removed
from the screen.
Hitting "Next" again confirms that the rejection happend since an alert is
presented saying "The file you want to clear local changes in doesn't exist as a
work in progress." However, the dialog box remains on the screen.
Since it is a modal dialog, the rest of the interface in inaccessible.
The whole page must be refreshed, reloading the editor.
Expected result:
----------------
Maybe some confirmation that the file was rolled back. And the dialog should be
closed.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=64362&edit=1
Thread (4 messages)