Doc #62453 [Com]: Terrible sample code for mcrypt_encrypt

Edit report at https://bugs.php.net/bug.php?id=62453&edit=1 ID: 62453 Comment by: nikic@php.net Reported by: maarten dot bodewes at gmail dot com Summary: Terrible sample code for mcrypt_encrypt Status: Closed Type: Documentation Problem Package: Documentation problem PHP Version: 5.4.4 Assigned To: ircmaxell Block user comment: N Private report: N New Comment: @maarten: I'd like to remove the utf8_encode() line from the sample code. For most people (who most likely are using UTF8, even if they are not aware of it) this will just result in double encoding. And if they are not using UTF8, then utf8_encode() may not be the most appropriate function to use (rather iconv or mb_convert_encoding with the encoding they are using.) Are you okay with that? Previous Comments: ------------------------------------------------------------------------ [2013-03-27 23:49:52] gwynne@php.net This bug has been fixed in the documentation's XML sources. Since the online and downloadable versions of the documentation need some time to get updated, we would like to ask you to be a bit patient. Thank you for the report, and for helping us make our documentation better. ------------------------------------------------------------------------ [2013-03-27 23:48:44] gwynne@php.net Automatic comment from SVN on behalf of gwynne Revision: http://svn.php.net/viewvc/?view=revision&revision=329941 Log: Fix bug #62453 ------------------------------------------------------------------------ [2012-08-13 00:45:39] maarten dot bodewes at gmail dot com Hello? Anybody? Are you just going to let this fester? ------------------------------------------------------------------------ [2012-07-15 20:54:20] maarten dot bodewes at gmail dot com I've tried to contact the dev. to apply this change for me. If you want I can apply it myself, but I quickly got lost in the interface where I should apply the change (and I don't have enough time to get fully acquainted with it). If anybody wants the new code applied, please do so, or guide me through the process. ------------------------------------------------------------------------ [2012-07-03 12:47:54] ircmaxell@php.net Maarten, Sounds good to me. I would apply it for you, but I'd rather give credit where credit is due. Could you make the change on http://edit.php.net ? All you need to do is make a patch from that console (I believe you right click your work in progress tab, and there should be an option to submit a patch). Then just post back here with the username that you used and I'll commit it for you. That way you get credit for the change instead of me. If that's too much, let me know and I'll apply it for you. But I would rather you get the credit for it. Thanks, Anthony ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=62453 -- Edit this bug report at https://bugs.php.net/bug.php?id=62453&edit=1