Re: svn: /phpdoc/en/trunk/reference/array/functions/ array-product.xml

On Feb 28, 2013, at 1:15 PM, Jean-Sébastien Hedde <jeanseb@au-fil-du.net> wrote: > On 28/02/2013 22:08, Hannes Magnusson wrote: >> Right, but you are linking to the bug report and linking to a bug >> report for some reason.. >> >> -Hannes > > I was just linking to the explanation of the change as in the change log. Hello Jean-Séb, Please update the changelog entry to simply say what the change was. It does not need (nor should it) link to the bug report. Or maybe we should link to bug reports but it's not something we do today. Interesting thought, though. So a new version of your entry might read as: The product of an empty array is now 1, when before this function would return 0 for an empty array. I understand your desire to help people understand why the change was made, but that's something we can document instead of linking to bug reports. If so, maybe: In accordance to the multiplicative identity of an element, PHP now treats the product of an empty array as 1. Before, an empty array was treated as an additive identity, so this function would return 0. Trouble is, I have no idea what I just wrote so it may be wrong. ;) Sorry for the bike shedding, but I hope the above helps clarify. Regards, Philip