Re: svn: /php doc/ doc-base/trunk/install-win.xml.in en/t runk/faq/installation.xml en/trunk/faq/obtainin g.xml en/trunk/features/commandline.xml en/
trunk/install/cloud/azure.xml en/trunk/install/ pecl.xml en/trunk/install/windows/index.xml en/trunk/ins
| From: | Philip Olson | Date: | Wed, 01 Jun 2016 16:07:42 +0000 |
| Subject: | Re: svn: /php doc/ doc-base/trunk/install-win.xml.in en/t runk/faq/installation.xml en/trunk/faq/obtainin g.xml en/trunk/features/commandline.xml en/ trunk/install/cloud/azure.xml en/trunk/install/ pecl.xml en/trunk/install/windows/index.xml en/trunk/ins |
||
| References: | 1 2 | Groups: | php.doc.cvs |
| Request: | Send a blank email to doc-cvs+get-14160@lists.php.net to get a copy of this message | ||
Howdy,
> On Jun 1, 2016, at 3:57 AM, Christoph Becker <cmbecker69@gmx.de> wrote:
>
> Hi Matt!
>
> On 01.06.2016 at 08:23, Matt Ficken wrote:
>
>> mattficken Wed, 01 Jun 2016 06:23:30 +0000
>>
>> Revision:
>> http://svn.php.net/viewvc?view=revision&revision=339251
>>
>> Log:
>> updating install/windows and pages linking to it
>
> Thanks for bringing the Windows installations instructions up to date.
>
>> Changed paths:
>> U phpdoc/doc-base/trunk/install-win.xml.in
>
> I'm afraid it is not possible to translate this file, and it appears
> that the information there is identical to install/windows/index.php.
> What to do?
I suspect it should use entities like it did before, and not text like
was inserted. So, reverted, then updated (if file entity names changed
or were added).
Also, this patch has the following stuff that needs to be fixed:
- Patch treats \n\n like a <para>, when really a <para> is required.
Please use <para> in many more places (not \n\n). See manual.xml
for a good example of this issue.
- External links belong in global.ent and not inside the XML, the
global.ent file is stored in doc-base
- Remove TODO as this was inserted into a few places
- Smaller issue: whitespace, some lines are really really long
- If IDs were removed, add them to the 404 handler in web/php.git,
which might mean linking x.foo to x.legacy.foo
Also, good to see documentation being updated for the 21st century, nice
work :)
Regards,
Philip