Re: cvs: phpdoc /en/reference/filesystem/functions chgrp.xml clearstatcache.xml fgetss.xml fileinode.xml ftruncate.xml link.xml pclose.xml
readfile.xml rewind.xml rmdir.xml
| From: | Maciek Sokolewicz | Date: | Tue, 14 Oct 2008 19:34:41 +0000 |
| Subject: | Re: cvs: phpdoc /en/reference/filesystem/functions chgrp.xml clearstatcache.xml fgetss.xml fileinode.xml ftruncate.xml link.xml pclose.xml readfile.xml rewind.xml rmdir.xml |
||
| References: | 1 2 3 | Groups: | php.doc.cvs |
| Request: | Send a blank email to doc-cvs+get-2238@lists.php.net to get a copy of this message | ||
Ross Masters wrote:
"Maciek Sokolewicz" <tularis@gmail.com> wrote in message news:48F4C8D6.2000607@php.net...Most are ok, but I don't understand why you changed the echo statement to a printf() call in chgrp.xml +echo "$filename's Group ID @ " . time() . ": " . filegroup($filename) . "\n"; would have been ok. Adding extra functions might make it easier on the eyes for you, but (and I'm only guessing here) most PHP developers rarely use printf and thus it's an extra hurdle for them to figure out what you're doing in the example. Everyone knows the basic echo structure. Same thing goes for clearstatcache.xml; fgetss.xml, fileinode.xml, ftruncate.xml, etc. comply fully with the standards. link.xml was fine already, you didn't have to change double quotes to single ones. It's best practice to, I agree, but would usually not warrant its own commit :)Ross Masters wrote:Could you suggest an alternative please? Thanks,ross Tue Oct 14 15:10:17 2008 UTCIt might be just me, but printf is even more against PEAR coding standards than echo() . . .Modified files: /phpdoc/en/reference/filesystem/functions chgrp.xml clearstatcache.xml fgetss.xml fileinode.xml ftruncate.xml link.xml pclose.xml readfile.xml rewind.xml rmdir.xml Log:Fixing example code to comply with PEAR coding standards.