Re: svn: /phpdoc/en/trunk/reference/exec/ book.xml

2009/11/20 Hannes Magnusson <hannes.magnusson@gmail.com>: > On Thu, Nov 19, 2009 at 11:33, Richard Quadling > <rquadling@googlemail.com> wrote: >> 2009/11/19 Jakub Vrana <vrana@php.net>: >>> vrana                                    Thu, 19 Nov 2009 10:15:03 >>> +0000 >>> >>> Revision: >>> http://svn.php.net/viewvc?view=revision&revision=290969 >>> >>> Log: >>> Use cmd.exe on Windows (bug #48345) >>> >>> Bug: http://bugs.php.net/48345 (Closed) system() >>> function docs: how to prevent cmd.exe >>> >>> Changed paths: >>>    U   phpdoc/en/trunk/reference/exec/book.xml >>> >>> Modified: phpdoc/en/trunk/reference/exec/book.xml >>> =================================================================== >>> --- phpdoc/en/trunk/reference/exec/book.xml     2009-11-19 08:53:30 UTC (rev 290968) >>> +++ phpdoc/en/trunk/reference/exec/book.xml     2009-11-19 10:15:03 UTC (rev 290969) >>> @@ -14,6 +14,15 @@ >>>    Those functions provide means to execute commands on the >>>    system itself, and means to secure such commands. >>>   </para> >>> +  <note> >>> +   <para> >>> +    All execution functions call the commands through >>> +    <literal>cmd.exe</literal> under Windows. Therefore the user calling >>> these >>> +    functions needs appropriate privilege to run this command. The only >>> +    exception is <function>proc_open</function> with >>> +    <literal>bypass_shell</literal> option. >>> +   </para> >>> +  </note> >>>  </preface> >>>  <!-- }}} --> >>> >>> >> >> Specifically, calls go through the shell specified by %COMSPEC%. This >> MAY not be cmd.exe. There are replacement shells. >> > > I don't think that has any meaning to Jakub, could you fix it? :) > > -Hannes > Actually, Jakub's patch to phpdoc is fine (as we no longer support older versions of windows, commenting on command.com as the shell is no longer necessary). But, the issue is that COMSPEC should be determining the shell, NOT PHP. I've raised a bug for this issue (http://bugs.php.net/bug.php?id=50271). Once that's patched, then I assume from V5.3.2+ COMSPEC will be used rather than checking the windows version and hard-coding cmd.exe/command.com Richard. -- ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 ZOPA : http://uk.zopa.com/member/RQuadling