Re: svn: /phd/trunk/ package.xml phpdotnet/phd/Package/Generic/XHTML.php

From: Date: Sun, 16 May 2010 22:34:26 +0000
Subject: Re: svn: /phd/trunk/ package.xml phpdotnet/phd/Package/Generic/XHTML.php
References: 1 2  Groups: php.doc.cvs 
Request: Send a blank email to doc-cvs+get-6662@lists.php.net to get a copy of this message
On 15 May 2010 13:48, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Fri, May 14, 2010 at 18:02, Richard Quadling <rquadling@php.net> wrote: >> rquadling                                Fri, 14 May 2010 16:02:45 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=299387 >> >> Log: >> Allow <void/> as return type for methodsynopsis tags rather than >> <type>void<\type> >> >> Changed paths: >>    U   phd/trunk/package.xml >>    U   phd/trunk/phpdotnet/phd/Package/Generic/XHTML.php >> >> Modified: phd/trunk/package.xml >> =================================================================== >> --- phd/trunk/package.xml       2010-05-14 15:55:36 UTC (rev 299386) >> +++ phd/trunk/package.xml       2010-05-14 16:02:45 UTC (rev 299387) >> @@ -71,6 +71,7 @@ >>     - Added 'package_dirs' config option to specify package directories to >> autoload from (Hannes) >>     - Corrected grammar in Danish translation + fixed encoding (Daniel Egeberg) >>     - Allow colored output on Windows, but not by default (Richard Quadling) >> +    - Allow &lt;void/&gt; as return type for methodsynopsis tags rather than >> &lt;type&gt;void&lt;\type&gt; (Richard Quadling) > > Typo... \type > Doh! > >> Modified: phd/trunk/phpdotnet/phd/Package/Generic/XHTML.php >> =================================================================== >> --- phd/trunk/phpdotnet/phd/Package/Generic/XHTML.php   2010-05-14 15:55:36 UTC (rev >> 299386) >> +++ phd/trunk/phpdotnet/phd/Package/Generic/XHTML.php   2010-05-14 16:02:45 UTC (rev >> 299387) >> @@ -240,6 +240,7 @@ >>         'set'                   => >> 'format_container_chunk_top', >>         'setindex'              => 'format_chunk', >>         'shortaffil'            => >> 'format_suppressed_tags', >> +        'sidebar'               => 'format_note', > > That should get its own news entry > > Will do. >> -    public function format_void($open, $name, $attrs) { >> -        return ' ( <span >> class="methodparam">void</span>'; >> +    public function format_void($open, $name, $attrs, $props) { >> +        if ($props['sibling'] == 'methodname') { >> +               return ' ( <span >> class="methodparam">void</span>'; >> +       } else { >> +               return '<span class="type"><span >> class="type void">void</span></span>'; >> +       } > > > Don't we always create a link for the return types in the PHP package? > The PHP package may need to overwrite that method to provide > consistent linking.. > I've only returned what is currently returned for <type>void</type>. Not sure what else is appropriate. > -Hannes > > -- > PHP Documentation Commits Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html EE4Free : http://www.experts-exchange.com/becomeAnExpert.jsp Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 ZOPA : http://uk.zopa.com/member/RQuadling

« previous php.doc.cvs (#6662) next »