Re: svn: /phpdoc/en/trunk/reference/geoip/functions/ geoip-id-by-name.xml

Hi Kalle, thanks for taking a look. It doesn't return the Internet connection speed or the Net Speed. This is imposible for a lookup tool. It returns the connection type or if you want the Internet Connection Speed Type: Dialup, Cable/DSL, Corporate or Unknown. I changed the title and the description that it was wrong anyway: "The geoip_id_by_name() function will return the country and region corresponding to a hostname or an IP address" ...somebody copy/pasted this from another GeoIP function. If you take a look to the rest of the document it always mention to "The connection type". Thats way I changed to make it consistent with the rest of the document. Please let me know what you think. Thanks! On Tue, Aug 3, 2010 at 2:34 AM, Kalle Sommer Nielsen <kalle@php.net> wrote: > Hi Yago > > 2010/8/3 Yago Ferrer <yago@php.net>: > > yago Tue, 03 Aug 2010 09:26:49 +0000 > > > > Revision: > > http://svn.php.net/viewvc?view=revision&revision=301827 > > > > Log: > > To make it less confusing I changed to: Internet connection type. > > By looking at the pecl/geoip extension sources, which leads to the > internal definition of GeoIP_id_by_name(), it says that it returns the > net speed, not the connection type, so I would assume that its > correct. That is unless you tested it yourself using pecl/geoip? > > -- > regards, > > Kalle Sommer Nielsen > kalle@php.net > -- Yago Ferrer