Re: svn: /phd/trunk/phpdotnet/phd/Package/PHP/ EnhancedCHM.php

2011/2/24 Philip Olson <philip@roshambo.org>: > > On Feb 23, 2011, at 5:47 AM, Richard Quadling wrote: > >> rquadling                                Wed, 23 Feb 2011 13:47:46 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=308601 >> >> Log: >> Updated enhanced format to use TEMP and to cache the usernotes. >> Uses bz2 extension rather than external executable. >> Decompresses and converts all.bz2 on the fly - no all.bz2 or all files saved. > > Why use TEMP at all? It's causing errors for people (*nix users) without it being set. I > wrote a patch that checks and uses Config::output_dir() if TEMP is not set, but now wonder why it > was changed so haven't committed. In a word - caching. The CHMs are built for many languages. The current build-chms.php script wipes the output directory between each manual build. I needed a place to put the usernotes that would survive more than 1 language build. Otherwise, for every language, the notes would have to be downloaded and expanded every time. What I would like to do is alter PhD so that --output-dir acts as a base directory. All output would be put to a subdirectory based upon the --lang value ... /rendering/en /rendering/fr /rendering/ru The usernotes would then be /rendering/usernotes No need to delete anything until the entire run is complete. Hannes said this would be a problem for BC - true enough. Adding another option (--include-lang) would seem daft as most users would wonder why they don't just put the lang part into the output dir. I could have used a relative path (Config::output_dir() . '..' . DIRECTORY_SEPARATOR), but then I'm going outside of the output-dir. Using Temp seemed the best option. > > Btw, nice work implementing the bz2 extension. Thank you. > > Regards, > Philip -- Richard Quadling Twitter : EE : Zend @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY