Re: svn: /phd/trunk/ package-pman.php package.xml phpdotnet/phd/Options/Interface.php phpdotnet/phd/Options/Parser.php
phpdotnet/phd/Package/Generic/ChunkedXHTML.php phpdotnet/phd/Package/Generic/Manpage.php phpdotnet/phd/Package/Generic/To
| From: | Hannes Magnusson | Date: | Fri, 01 Apr 2011 19:35:47 +0000 |
| Subject: | Re: svn: /phd/trunk/ package-pman.php package.xml phpdotnet/phd/Options/Interface.php phpdotnet/phd/Options/Parser.php phpdotnet/phd/Package/Generic/ChunkedXHTML.php phpdotnet/phd/Package/Generic/Manpage.php phpdotnet/phd/Package/Generic/To |
||
| Groups: | php.doc.cvs | ||
| Request: | Send a blank email to doc-cvs+get-7910@lists.php.net to get a copy of this message | ||
On Fri, Apr 1, 2011 at 18:00, Richard Quadling <rquadling@php.net> wrote:
> rquadling Fri, 01 Apr 2011 16:00:11 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=309879
>
> Log:
> Allow output directories to be a nested directory.
>
Hah. Nice fixed.
I've never actually done this though :P
To be annoying (eye for an eye!);
Modified: phd/trunk/render.php
===================================================================
--- phd/trunk/render.php 2011-04-01 15:11:47 UTC (rev 309878)
+++ phd/trunk/render.php 2011-04-01 16:00:11 UTC (rev 309879)
@@ -31,8 +31,8 @@
}
if (!file_exists(Config::output_dir())) {
v("Creating output directory..", VERBOSE_MESSAGES);
- if (!mkdir(Config::output_dir())) {
- v("Can't create output directory", E_USER_ERROR);
+ if (!mkdir(Config::output_dir(), 0777, True)) {
+ v("Can't create output directory : %s", Config::output_dir(),
E_USER_ERROR);
}
True? :)
Tajchreber also made an excellent point on IRC;
18:51 < yawk> why is that mkdir statement for the output dir in every
one of the formats and not somewhere higher in the process?
18:52 < yawk> so that its called once and then the formats that need
an extra dir (eg. styles) can create that seperately
We already test options and stuff, so why don't we verify the dir
during, for example, the argument parsing?
It does introduce a minor race condition, but we already have that in
the formats anyway - and it is such an non-issue that noone cares.
At the very least, the formats should be inheriting these sort of
things from the base/generic formats.
-Hannes