Re: svn: /phd/trunk/ package_php.xml phpdotnet/phd/Package/PHP/CHM.php

On 6 June 2011 15:49, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Mon, Jun 6, 2011 at 14:19, Richard Quadling <rquadling@php.net> wrote: >> rquadling                                Mon, 06 Jun 2011 12:19:17 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=311863 >> >> Log: >> Added support for local CSS files rather than forcing them to be from >> http://www.php.net/styles >> >> Changed paths: >>    U   phd/trunk/package_php.xml >>    U   phd/trunk/phpdotnet/phd/Package/PHP/CHM.php >> >> Modified: phd/trunk/package_php.xml >> =================================================================== >> --- phd/trunk/package_php.xml   2011-06-06 10:45:33 UTC (rev 311862) >> +++ phd/trunk/package_php.xml   2011-06-06 12:19:17 UTC (rev 311863) >> @@ -42,6 +42,7 @@ >>   <notes> >>     - Fixed Bug #54436 - gzip issues with -P PHP -f manpage (Moacir) >>     - Fixed bug #53536 - Small display bug in attribute description for >> mysqli-&gt;insert_id >> +    - Added support for local CSS files (Richard Quadling) > > > I don't think the --css option differentiates between local as > external, it goes through the streams layer anyway.. so I don't quite > understand what this entry means? > .. And we in general only use the first name of developers in news > entries (and who fixed the entry above it?) > > -Hannes PHP CHM function fetchStylesheet() gets the file directly from http://www.php.net/styles. From nearly day 1 of the class : http://svn.php.net/viewvc/phd/trunk/phpdotnet/phd/Package/PHP/CHM.php?r1=260438&r2=260498#l333 This was amended to allow a different filename to be used (or site.css if none supplied). http://svn.php.net/viewvc/phd/trunk/phpdotnet/phd/Package/PHP/CHM.php?r1=300138&r2=307979#l429 I just added a realpath() check to allow for a local file to be used. Theoretically, by adding a chm with an @import() clause in it, you could allow for third party customization of the CHM file. With no interaction required on our part. See bug http://bugs.php.net/bug.php?id=48707 Your commit. http://svn.php.net/viewvc/phd/trunk/package_php.xml?view=annotate#l44 http://svn.php.net/viewvc/phd/trunk/package_php.xml?r1=310309&r2=310310& I don't think this has been fixed. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea