Re: svn: /phpdoc/en/trunk/reference/stream/streamwrapper/ stream-eof.xml stream-read.xml

That is missing context. if (feof($stream)) {} does not call stream_read() and the return value of stream_eof() is obviously not ignored. -Hannes On Sun, Jun 12, 2011 at 09:06, Karoly Negyesi <chx@php.net> wrote: > chx                                      Sun, 12 Jun 2011 07:06:02 +0000 > > Revision: > http://svn.php.net/viewvc?view=revision&revision=312085 > > Log: > We really needs warnings based on > http://bugs.php.net/bug.php?id=40047 > > Changed paths: >    U   phpdoc/en/trunk/reference/stream/streamwrapper/stream-eof.xml >    U   phpdoc/en/trunk/reference/stream/streamwrapper/stream-read.xml > > Modified: phpdoc/en/trunk/reference/stream/streamwrapper/stream-eof.xml > =================================================================== > --- phpdoc/en/trunk/reference/stream/streamwrapper/stream-eof.xml       2011-06-12 06:27:02 > UTC (rev 312084) > +++ phpdoc/en/trunk/reference/stream/streamwrapper/stream-eof.xml       2011-06-12 07:06:02 > UTC (rev 312085) > @@ -54,6 +54,17 @@ >  </refsect1> >  --> > > + <refsect1 role="notes"><!-- {{{ --> > +  &reftitle.notes; > +  <warning> > +    <para> > +      As long as <methodname>streamWrapper::stream_read</methodname> returns > +      a non-empty string the return value of > +      <methodname>streamWrapper::stream_eof</methodname> is ignored. > +    </para> > +  </warning> > + </refsect1><!-- }}} --> > + >  <refsect1 role="seealso"> >   &reftitle.seealso; >   <para> > > Modified: phpdoc/en/trunk/reference/stream/streamwrapper/stream-read.xml > =================================================================== > --- phpdoc/en/trunk/reference/stream/streamwrapper/stream-read.xml      2011-06-12 06:27:02 > UTC (rev 312084) > +++ phpdoc/en/trunk/reference/stream/streamwrapper/stream-read.xml      2011-06-12 07:06:02 > UTC (rev 312085) > @@ -99,6 +99,13 @@ >     <acronym>EOF</acronym> is assumed. >    </para> >   </note> > +  <warning> > +    <para> > +      As long as <methodname>streamWrapper::stream_read</methodname> returns > +      a non-empty string the return value of > +      <methodname>streamWrapper::stream_eof</methodname> is ignored. > +    </para> > +  </warning> >  </refsect1><!-- }}} --> > >  <refsect1 role="seealso"> > > > -- > PHP Documentation Commits Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >