Re: svn: /phpdoc/en/trunk/reference/network/functions/ http-response-code.xml
| From: | Philip Olson | Date: | Wed, 13 Jul 2011 06:57:46 +0000 |
| Subject: | Re: svn: /phpdoc/en/trunk/reference/network/functions/ http-response-code.xml | ||
| References: | 1 2 3 | Groups: | php.doc.cvs |
| Request: | Send a blank email to doc-cvs+get-8475@lists.php.net to get a copy of this message | ||
On Jul 12, 2011, at 6:49 AM, Paul Dragoonis wrote:
> Phillip,
>
>
> On Tue, Jul 12, 2011 at 6:03 AM, Philip Olson <philip@roshambo.org> wrote:
>> Greetings Paul,
>>
>> This commit changed line endings for this file, therefore it's nearly impossible to
>> see the actual changes.
>>
>> Now, it contained Windows line endings (which are bad) but please, in the future, do WS
>> commits separately.
>
> This page is somewhat incomplete, it was 5am and I was passing out so
> I wanted to submit something to continue with today. Sorry about the
> whitespace, i used edit.php.net editor directly. Does the editor
> usually give WS issues?
There is a draft folder. ;) But, the editor appears to convert line endings so it's something
to look into. Adding a detection SVN hook may go too far, but one day when we cleanup configure.php
then we can add similar tools. For now, I'll go through the entire doc tree and convert them in
one single commit. Luckily, they are rare.
>> As for the commit, it appears you added an example within a parameters description. I
>> don't think we should do that. Also, it appears there's some PHP 5.4 specific code in the
>> main example, so this man page requires a changelog entry.
>
> Yes, since it's a new function it'll need a changelog entry for
> 5.4.0+. I hadn't gotten that far yet :-)
I don't think it's worth making a commit without this information, but this is me being an
old timer nitpicky perfectionist. But, I wanted to make sure that you were aware of changelogs.
Also, it's easy to forget future ideas as temporary often becomes permanent.
>> "it appears you added an example within a parameters description. I don't think
>> we should do that."
>
> I copied that idea from www.php.net/header. Why is it accepted to do
> so on header() but not for this function?
Oh, I didn't notice that but it's rare. It doesn't look so bad, but I don't see
the value.
Regards,
Philip