Re: svn: /phd/trunk/ phpdotnet/phd/Format.php phpdotnet/phd/Package/Generic/PDF.php phpdotnet/phd/Package/Generic/XHTML.php
phpdotnet/phd/Package/PEAR/XHTML.php tests/php/TestChunkedXHTML.php tests/php/bug49101-1.phpt tests/php/bug49101-2.p
| From: | Hannes Magnusson | Date: | Wed, 08 Feb 2012 13:46:39 +0000 |
| Subject: | Re: svn: /phd/trunk/ phpdotnet/phd/Format.php phpdotnet/phd/Package/Generic/PDF.php phpdotnet/phd/Package/Generic/XHTML.php phpdotnet/phd/Package/PEAR/XHTML.php tests/php/TestChunkedXHTML.php tests/php/bug49101-1.phpt tests/php/bug49101-2.p |
||
| Groups: | php.doc.cvs | ||
| Request: | Send a blank email to doc-cvs+get-9563@lists.php.net to get a copy of this message | ||
On Tue, Feb 7, 2012 at 07:30, Alexey Borzov <avb@php.net> wrote:
> avb Tue, 07 Feb 2012 06:30:24 +0000
>
> Revision: NJTXçÕ
> ÁŒýhttp://svn.php.net/viewvc?view=revision&revision=323107
>
> Log:
> * Get rid of redundant align and valign attributes on table-related tags, make non-redundant
> ones output as inline styles
> * Make some of the tests pass (they probably didn't even before my changes)
> * Changed <refsection> rendering in Package_PEAR_XHTML, format_refsect() has unfortunate
> side effects
>
> Changed paths:
> U phd/trunk/phpdotnet/phd/Format.php
> U phd/trunk/phpdotnet/phd/Package/Generic/PDF.php
> U phd/trunk/phpdotnet/phd/Package/Generic/XHTML.php
> U phd/trunk/phpdotnet/phd/Package/PEAR/XHTML.php
> U phd/trunk/tests/php/TestChunkedXHTML.php
> U phd/trunk/tests/php/bug49101-1.phpt
> U phd/trunk/tests/php/bug49101-2.phpt
> U phd/trunk/tests/php/bug49102-1.phpt
> U phd/trunk/tests/php/data/bug49102-1.xml
> U phd/trunk/tests/php/faq001.phpt
if (isset($attrs["colwidth"])) {
- $retval .= ' width="' .((int)$attrs["colwidth"]).
'"';
+ if (preg_match('/^\\d+\\*$/', $attrs['colwidth'])) {
+ // relative_length measure has no analogue in CSS and is
+ // unsupported in browsers, leave as is
+ $retval .= ' width="' . $attrs['colwidth'] .
'"';
+ } else {
+ // probably fixed width, use inline styles
+ $style[] = 'width: ' . $attrs['colwidth'];
+ }
}
Hmh
It used to be casted to an integer, no matter what.. now we wind up
with * in the <col width=""> attributes.. is that valid in html?
-Hannes