Re: cvs: docweb /include docweb_language.class.php /scripts gen_picture_info_all_lang.php /www revcheck.php

On Saturday 30 October 2004 18:47, Sean Coates wrote: > Vincent Gevers wrote: > > vincent Sat Oct 30 10:18:07 2004 EDT > > Log: > > - Stripslashes the translated entities > > I noticed this problem yesterday, too (after didou translated the > entities), and haven't had time to fix it, yet. > > I don't, however, think that stripslashes should be used natively. > Better would be turning off magic_quotes_runtime (and magic_quotes_gpc) > in .htaccess. If we are going to stripslashes, we'd be better creating a > wrapper ('safe_stripslashes(...)') that only strips if magic quotes are on. I'm using the suggested settings from INSTALL.txt sincve this morning php_flag register_globals Off php_flag magic_quotes_gpc Off php_flag magic_quotes_runtime Off php_flag short_open_tags On and the "\'" still appeared, so I added stripslashes and it worked :) looking into it.. <!ENTITY ... 'don\'t do this'> <!ENTITY ... "and he said \"you shouldn't do that\""> the last one always needs escaping.. Therefor I think the safe_stripslashes() (or a shorter name) would be the best solution. Vincent > > S >