Re: Bug #14698 Updated: pg_fetch_array() does not require row param

Hi! I'm sorry, I sent the patch to Jon, Jon was delighted (seeing no sense why the Postgres drivers behaves different than all other drivers). What I did not do (as so many programmers): Update the bloody docu. What I'd like to suggest: If anybody sends me an email with the file to edit, a mini-instruction ("type apt-get install xxxx" ideally) to get any tools for editing and is willing to check it in, please tell me. Sorry, I'm the guy to blame, please kick me to do the documentation. The change is fully backward compatible. Merry Chrismas, Georg On Wed, Dec 26, 2001 at 07:26:39AM -0000, yohgaki@php.net wrote: > ID: 14698 > Updated by: yohgaki > Reported By: junk-php@aontic.com > Status: Analyzed > Bug Type: Documentation problem > Operating System: Linux > PHP Version: 4.1.0 > Assigned To: yohgaki > New Comment: > > Thanks for checking the change :) > I'm the new module maintainer, so I'm asking previous module maintainers about it. > Since MySQL seems it does the same, I'll keep this behavior probably, but it is not a promise > yet. ;) > > > Previous Comments: > ------------------------------------------------------------------------ > > [2001-12-26 02:19:28] junk-php@aontic.com > > Implemented 6 months ago by jon (1.112) pgsql.c. > Looks reasonable. > > > ------------------------------------------------------------------------ > > [2001-12-26 02:13:51] junk-php@aontic.com > > Works wonderfully without the row. That's certainly a win convienence wise, especially for > folks coming over from mysql where the loop syntax is trivial > > (while $row = fetch()) > {} > > I'd prefer to see the docs change then the functionality. I'll take a look at the > code itself but it is hard to see how this is a performance loss, most users end up keeping a > counter anyways. > > Why do you prefer making the row required? It seems like a silly added restriction, especially > when I bet 80% of the cases where the function is called don't need it. > > ------------------------------------------------------------------------ > > [2001-12-26 02:09:44] yohgaki@php.net > > Additional comment: > All pg_fetch_* works as reporter mentioned, but > DO NOT take advantage of this. > I may change behavior after I check php3 and php4 CVS log :) > > > ------------------------------------------------------------------------ > > [2001-12-26 02:06:55] yohgaki@php.net > > I've checked current code. Reporter is right. > I need to check when this has been changed and I think row should be required parameter. > I'll keep this behavior if and only if this was the implemented from the beginning :) > (Current code internally advance row in result structure) > > So DO NOT take advantage of this. > > > ------------------------------------------------------------------------ > > [2001-12-26 01:57:46] junk-php@aontic.com > > array pg_fetch_array (resource result, int row [, int result_type]) > > makes int row appear required, when it is actually optional. > > > > ------------------------------------------------------------------------ > > > > Edit this bug report at > http://bugs.php.net/?id=14698&edit=1 > > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net > For additional commands, e-mail: php-dev-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net >