Re: Problem with the revcheck page
| From: | Thomas Schöfbeck | Date: | Thu, 19 Dec 2002 21:46:29 +0000 |
| Subject: | Re: Problem with the revcheck page | ||
| References: | 1 2 3 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969350337@lists.php.net to get a copy of this message | ||
Hi all,
I can't see any differences in the behavior of "../" between cgi- and cli-version (at least on my win-box, and I would wonder if it is on Linux, and if, somebody should report it to qa), but it seems to be the old story of currentdir, workdir, etc. on the different machines.
If I'm right, the call from the makefile
"PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.php $(LANGDIR) > revcheck.html"
sets an environment-variable before it calls revcheck (But I'm not an expert on *nixes).
In this case, a fix for the generating machine should be to change the lines 93-98 in revcheck.php with:
if (isset($_ENV['PHPDOCDIR']) && is_dir($_ENV['PHPDOCDIR']))
$DOCDIR = $_ENV['PHPDOCDIR']."/"; // run via make
else
$DOCDIR = "../"; //run directly from script-dir
NOTE: Under Win and Cygwin you need the above isset(), because is_dir($not_set_var) returns true, and PHPDOCDIR=$(srcdir) doesn't set a Win-env-var for the php.exe.
So it's not a perfect solution, but it should work.
Would be great if somebody could check it on *nix (the best would the generating machine) before it gets committed (and changed again ;-).
So far my 2 cents,
Thomas
Gabor Hojtsy wrote:
As far as I have seen Friedhelm committed a fix to solve this problem [it is because of the CGI/CLI differences]... GobaThe same to pt_BR Fernando Martin Samesch escreveu:Hi, http://www.php.net/manual/de/revcheck.html.gz tells me that "The de language code is not valid". Is it broken? Martin