Re: cvs: phpdoc /en/appendices wrappers.xml

> > OK, how can that be started? It cannot be automatically detected, > > what tranlation group a CVS user belongs AFAIK... > > right, but we can check the translation.xml files... Well, yes :) But I don't think that anybody would like to volunteer now to extract CVS user names and revoke Karma from them... > > And actually the en commit is something to allow for translators, > > so they can correct errors found in the documentation while they > > translate (though they don't really seem to do it). > > I think it is not too bad if they have to submit a patch for it. If for > instance somebody commits a lot to the EN tree too he can of course get > access to that too. Patches sent in to phpdoc are mostly handled with: "get a CVS account" or "get karma", as far as I can remember, guys don't apply patches here, including me ;) > > Maybe we can add a special commit check script into CVSROOT to check > > for something in a committed English XML file, which ensures that it > > is English. If it finds that it is not English, it can refuse to > > commit it. AFAIK something like this is possible in CVS. We only need > > to specify the criteria for English XML files (like some common > > English word used). > > xml? :D It's hard to define such a word though... Well, I thought about something: if (!preg_match("!(the|with|for)!", $committed_file)) { refuse_commit(); } As far as I can see, commitinfo may be able to do something like this, but unfortunately the commitedd file contents is not available for it... # The "commitinfo" file is used to control pre-commit checks. # The filter on the right is invoked with the repository and a list # of files to check. A non-zero exit of the filter program will # cause the commit to be aborted. > I think we just > should start by giving new users only karma to their language module. > The translators that already have an account are usually being told not > to commit to the english branch. Well, this is a good start ;) But it would be nice if everybody would add users consitently ;) Goba