Re: WS, phpdoc, and you :)
| From: | Philip Olson | Date: | Tue, 08 Apr 2003 19:26:01 +0000 |
| Subject: | Re: WS, phpdoc, and you :) | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969352505@lists.php.net to get a copy of this message | ||
On Tue, 8 Apr 2003, Sean Coates wrote:
> Sorry, I'm pretty new at this:
>
> > a) Always check unified diffs before submit as to
> > not miss any Whitespace changes. Makes it more
> > difficult to see what actually changed.
>
> Not sure what you mean by this.
Look at your patch, it has much more than the simple
addition of a faq, it shows changes that really do
nothing except maybe remove a space to the end of a
line or something. Example:
- See also
- <link linkend="ref.array">Array Functions</link> and
+ See also
+ <link linkend="ref.array">Array Functions</link> and
First viewing a diff will weed out these accidental
changes as to eventually produce a readable patch.
> > b) Check our coding standards, we always put the
> > braces like:
> >
> > if () {
> > } else {
> > }
>
> No problem. I looked through the documentation howto, and I may have
> just overlooked this, but I don't see standards in there. Are we using
> the PEAR standard?
Yeah. I thought it was official but I also don't see
this in the howto, it'll be added.
Regards,
Philip