#23192 [Asn]: mb_encode_mimeheader mangles long lines?

ID: 23192 User updated by: jc at mega-bucks dot co dot jp Reported By: jc at mega-bucks dot co dot jp Status: Assigned Bug Type: Documentation problem Operating System: Red Hat Linux 8.0 PHP Version: 4.3.2RC1 Assigned To: moriyoshi New Comment: Ok. Thanks for all the hard work. I'll keep an eye out for when bug #23250 is closed so that I can understand what HTML-ENTITIES does. In the meantime I'll try out your solution and see if it works. Previous Comments: ------------------------------------------------------------------------ [2003-04-17 08:14:58] moriyoshi@php.net ???! This is still a valid bug report and I've marked as assigned to indicate other volunteers that I'll fix the part of the document regarding this issue. As for HTML-ENTITIES, I really feel & admit the insufficiency of docs and so I did register a new entry for it. See bug #23250. ------------------------------------------------------------------------ [2003-04-16 21:21:33] jc at mega-bucks dot co dot jp I want to make PHP better and of course make the work of the people in charge of checking bug reports easier so I have to ask: Why doesn't this belong in a bug report? From what I have understood from your comments, there is no bug in mb_encode_mimeheader() *but* there is a problem with the documentation. So there is a bug, not with the function but with the documentation no? For me a bug is when a function does not behave as documented or gives a "broken" result when given valid input. In this case I gave valid input to the function (the RFC says what to do when the input string is longer than 76 chars) and the function gave back a broken header ... At the very least there is bug in the docs because it does not state that mb_encode_mimeheader() is not guaranteed to work will double-byte strings that are too long? I'll happilly submit "report" these to the i18n list instead, I just thought here was the better place since the function *is* broken and should be fixed or the documentation should fixed :) Oh, and what is "HTML-ENTITIES"? ------------------------------------------------------------------------ [2003-04-16 21:11:27] moriyoshi@php.net Yep, you are always welcome; but I'd rather to see your mb reports such as this one at the php-i18n list first than at the bug database.. ------------------------------------------------------------------------ [2003-04-16 20:45:26] jc at mega-bucks dot co dot jp Thanks. Should I also submit a documentation bug then concerning mb_encode_mimeheader()? I'll try out your solution. But what is "HTML-ENTITIES"? I cannot find any mention of that in the mb_string documenation? ------------------------------------------------------------------------ [2003-04-16 20:36:01] moriyoshi@php.net Hmm, yes, you are right and this is absolutely a problem that is caused by lack of words in the misleading documentation. Besides I forgot to append the correct diagnosis of this problem. mb_encode_mimeheader() can only deal with the most basic elements of strings. That is, it simply treats such a charcter that is represented by a numeric html entity as separate components. Therefore if line folding is done in the middle of a entity compounded of several characters, it inserts CRLF & space there and ends up cluttering the structure of the html entity. To avoid this, you have to do the following conversion on the string before passing it to mb_encode_mimeheader() $subject = mb_convert_encoding($subject, "ISO-2022-JP", "HTML-ENTITIES"); var_dump($subject); var_dump(mb_encode_mimeheader($subject, "ISO-2022-JP", "B")); ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/23192 -- Edit this bug report at http://bugs.php.net/?id=23192&edit=1