Re: modified XSL problems...

Gabor Hojtsy wrote:

Hi Tom! I just had a short free time to look into your modified XSL code, and I ended up in tears ;((( You have removed most of the CSS supporting stuff from html-common.xml, which was heavily relied on by the new CHM system, as well as you removed a phpdoc.object.title mode template and probably others, which were used in both the HTMLHelp sheets and the phpweb_xsl sheet heavily. <!-- Custom mode for titles for navigation without

     "Chapter 1" and other autogenerated content -->

<xsl:template match="*" mode="phpdoc.object.title"> <xsl:call-template name="substitute-markup">

    <xsl:with-param name="allow-anchors" select="0"/>
    <xsl:with-param name="template" select="'%t'"/>

</xsl:call-template> </xsl:template> Sorry, but didn't know that this is already in use, I've just read it when the commits for html, bightml, and fo were done. So I thought at the beginnig (knowing that at least TOCs doesn't work completely, and there were some small bugs in the existing files) I have enough time to write everything new to a complete set. Since both, html and bightml don't use css, etc., I left that out to save time and filesizes.

A 2nd reason was the big upgrade to docbook-xsl 1.60.1 (from 1.50?), where it was completely unsure, if all the "not-yet-working-styles" still work like before. htmlhelp is like fo a special thing, (which btw. meanwhile supported also by docbook-xsl but I didn't check yet how much changes would be needed), which should be handled as such. Just short to the tech-question: The above template is called by e.g. <xsl:apply-templates select="." mode="phpdoc.object.title"/> and the above template itself calls another template (substitute-markup), which calls <xsl:apply-templates select="." mode="title.markup"/>. So why don't we call immediately the second one, saving 2 steps?

I guess, you have clear reasons why you removed this stuff, probably knowing some better solution for these problems... But with all your modifications and the XSL stylesheet distribution upgrade, the phpweb and the new CHM sheets got far-far away from usability, and I am not willing to dig into what have you modified why... ;((( I think it would be double effort, as you know it best. As you removed the majority of the util templates and customizations I have added to the XSL sheets, it would be a ground-up learning effort for me, which I cannot volunteer for right now :((( That wasn't intended, I thought that I'll do everything (also chm and phpweb).

I just thought I'll build a new CHM for the guys, and see that it needs much work to do to make it work again in the new XSL customization system, especially that there were still some PHP magic regexps to make it perfect on the output, and those regexps won't find the HTML they are comfortable with, so the new CHM build system got crapped... ;( I can't promise proper results soon, because my flat is still a construction site.

Meanwhile we could copy the contents of the old common and html-common into the htmlhelp.xsl.in as a quick-fix, but I don't have an idea for the docbook-xsl-upgrade (except to use the old ones on your machine).

BTW this does not mean I don't value your contributions, or I don't like the new html_xsl output. As I said, I reallty like it, and it runs twice as fast as make html on my machine... But it has ugly side effects on phpweb_xsl and chm_xsl ;(((( Hmm... If that stuff really worked that good and is completely destroyed now: Why isn't it in production yet, after a year laying laying around in cvs for a year? OK, you've tested around with chm (what I didn't know, sorry), but how does this concern phpweb if it isn't used?

Cu, Thomas