Re: cvs: phpdoc /en/reference/array/functions array-combine.xml

hi,

Hi!

I disagree with these changes and don't consider them upgrades, I intentionally put the output in the example as to make a clean cut-n-paste example. In fact, there are times when I change it the other way around :) Why do you feel using <screen> is "an upgrade"?

I guess because that is somewhat in line with the guidelines, maybe... BTW I cannot find thic convention in the howto ;) But I remember to something like that. Anyway, I think this should be dealt with on a case by case basis. Sometimes it is OK to put the output into the code, and sometimes it is not.

Maybe a little convention in the howto will be needed then :) I think that everything enclosed between <programlisting> and </programlisting> tags should safely be copy/pasted in a PHP script. Here's what I suggest regarding this : If it's a "little" output, we can consider using the // style comment on the same line that produce it, for example : echo mysql_num_rows($result); // 5 If it's a "huge" output, like the result of a print_r(), we should use the <screen></screen> construction. Just my opinion :) Mehdi