Re: ./configure issue with fresh cvs checkout.

OK, I don't think this will break anything. Just go on and commit. Goba Jeremy S. Johnstone wrote:

Here is the diff that I propose. I think you can see what I was suggesting fairly easily. Index: missing-entities.php.in =================================================================== RCS file: /repository/phpdoc/scripts/missing-entities.php.in,v retrieving revision 1.10 diff -r1.10 missing-entities.php.in 44,47c44,55 < exec(

<     "@SP_OPTIONS@ $NSGMLS -f $NSGMLS_OUTPUT -i lang-@LANG@ -D . " .
<     "-s @SRCDIR@/dtds/dbxml-4.1.2/phpdocxml.dcl manual.xml"

< ); ---

if("@SP_OPTIONS@" == "") { exec(

       "$NSGMLS -f $NSGMLS_OUTPUT -i lang-@LANG@ -D . " .
       "-s @SRCDIR@/dtds/dbxml-4.1.2/phpdocxml.dcl manual.xml"

); } else { exec(

       "@SP_OPTIONS@ $NSGMLS -f $NSGMLS_OUTPUT -i lang-@LANG@ -D . "

.

       "-s @SRCDIR@/dtds/dbxml-4.1.2/phpdocxml.dcl manual.xml"

); }

-----Original Message----- From: Gabor Hojtsy [mailto:gabor@hojtsy.hu] Sent: Monday, July 14, 2003 3:28 AM To: Jeremy S. Johnstone Cc: phpdoc@lists.php.net Subject: Re: [PHP-DOC] ./configure issue with fresh cvs checkout.

I am having an issue with ./configure on a fresh copy of the source from phpdoc. The issue is coming about because of the file ./scripts/missing-entities.php. When the exec line is called which

runs

/usr/bin/onsgml it fails. The reason it is failing is because the exec

line doesn't seem to like having a space in front of the commandline

ie

" /usr/bin .... ". This space is caused by my system not needing any SP_OPTIONS before the command line. Shouldn't we put a little logic in

the line to make sure there is no whitespace at the front of the

command

before it is exec'd? I could easily implement the fix in a matter of seconds, but I wanted to check and see if anyone else is having the problem before I go and change anything.

Well, those SP_OPTIONS are related to languages, and noone reported this problem yet, though there are quite some people not having SP_OPTIONS I guess... It's not clear to me how would that fix look. Can you please create a diff first, so we can review it? Goba