#25183 [Fbk->Csd]: scan_makefile_in.awk problem

ID: 25183 User updated by: yiwakiri at st dot rim dot or dot jp Reported By: yiwakiri at st dot rim dot or dot jp -Status: Feedback +Status: Closed Bug Type: Documentation problem Operating System: All of Unix like system PHP Version: 4.3.2 New Comment: Is this Documentesion problem, Really? Ok. Let's change a place. It is once made close. Previous Comments: ------------------------------------------------------------------------ [2003-08-21 00:52:32] moriyoshi@php.net I think your patch does make sense. [case 1] LT_LIBRARY_SOURCES=a \ b \ c mode | sources | actual line 0 | | LT_LIBRARY_SOURCES=a \ 1 | a | b \ 1 | a b | c 0 | a b c | [case 2] LT_LIBRARY_SOURCES=a LT_LIBRARY_SOURCES_CPP=b \ c mode | sources | actual line 0 | | LT_LIBRARY_SOURCES=a 0 | a | LT_LIBRARY_SOURCES_CPP=b \ 1 | b | c 0 | b c | (In the second case both LT_LIBRARY_SOURCES.* lines should be honoured because those are different in their purpose.) Anyway, I don't think either this is the proper place for us to deal with this kind of issue at. Why not start a new thread in internals@lists.php.net? ------------------------------------------------------------------------ [2003-08-20 23:35:39] yiwakiri at st dot rim dot or dot jp it is nonsense -- PHP_EXTENSION macro is not outdated as long as a manual is seen. If it uses only PHP_NEW_EXTENSION, you repair a manual. (http://www.php.net/manual/en/zend.configuration-macros.php) It is the problem that what is offered cannot be used. Compatibility with back will be allowed, a manual will be collected, Which is good? ------------------------------------------------------------------------ [2003-08-20 22:57:21] sniper@php.net You're doing something wrong. And this is not the support forum for 3rd party extensions/development of such. Ask this kind of questions elsewhere. ------------------------------------------------------------------------ [2003-08-20 22:44:44] yiwakiri at st dot rim dot or dot jp Sorry. The category was mistaken. ------------------------------------------------------------------------ [2003-08-20 21:00:24] yiwakiri at st dot rim dot or dot jp Description: ------------ When creating the extension module of C / C++ mixture, It seems that scan_makefile_in.awk which is not correctly changed into PHP_NEW_EXTENSION macro from PHP_EXTENSION macro e.g. Makefile.in is LTLIBRARY_SOURCES = example1.c LTLIBRARY_SOURCES_CPP = example2.cxx Makefile -- snip -- .NOEXPORT: example2.lo: /home/iwakiri/swig/class/example2.cxx $(phplibdir)/example.la: ./example.la $(LIBTOOL) --mode=install cp ./example.la $(phplibdir) The first line's makerule is lost. Please change as follows: --- php-4.3.2/scan_makefile_in.awk Thu Mar 7 23:17:47 2002 +++ scan_makefile_in.awk Thu Aug 21 10:48:57 2003 @@ -5,7 +5,7 @@ mode == 0 && /^LTLIBRARY_SOURCES.*\\$/ { if (match($0, "[^=]*$")) { - sources=substr($0, RSTART, RLENGTH-1) + sources=sources substr($0, RSTART, RLENGTH-1) } mode=1 next @@ -13,7 +13,7 @@ mode == 0 && /^LTLIBRARY_SOURCES.*/ { if (match($0, "[^=]*$")) { - sources=substr($0, RSTART, RLENGTH) + sources=sources substr($0, RSTART, RLENGTH) } } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=25183&edit=1