#26759 [Opn->Bgs]: php documentation examples contain slow code

ID: 26759 Updated by: derick@php.net Reported By: kennyt@php.net -Status: Open +Status: Bogus Bug Type: Documentation problem PHP Version: Irrelevant Assigned To: kennyt New Comment: Don't smoke too much in the new year please. Previous Comments: ------------------------------------------------------------------------ [2004-01-01 04:51:12] vrana@php.net Double quotes and concatenation in output don't cause significant lost in performance. foreach too, furthermore it's better readable than while. Just my opinion. ------------------------------------------------------------------------ [2004-01-01 01:47:21] kennyt@php.net Those 'insignificant gains' do add up. Does anyone want to teach new PHP developers to [ab]use the language like that? [Not meaning to bait any flames; just trying to help] Ignoring any arguments about the necessity in real code, does anyone have objections? ------------------------------------------------------------------------ [2004-01-01 01:40:29] ben at slax0rnet dot com I truly can't believe the pickiness present here. In a lot of these cases the "optimizations" to example code would not equate to any significant gain in performance. ------------------------------------------------------------------------ [2003-12-31 22:46:16] kennyt@php.net Description: ------------ The php.net manual contains lots of examples that use less than desirable coding styles, such as unnecessary double quotes, concatenation in output (echo 'foo'.$bar;), bloaty loops (foreach(), which wastes memory, when just a while() is needed), etc. I'm happy to hit a good number of these pages, but I don't want to get killed over it. ;-) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26759&edit=1