Re: New docs: udm-alloc-agent-array udm-hash33
| From: | Mehdi Achour | Date: | Fri, 30 Jan 2004 12:44:44 +0000 |
| Subject: | Re: New docs: udm-alloc-agent-array udm-hash33 | ||
| References: | 1 2 3 4 5 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969358586@lists.php.net to get a copy of this message | ||
Bonjour David :)
Dear All, moved to the udm branch, see attached: udm-alloc-agent-array- udm-hash32 as always comments and suggestions are very welcome.Excellent work :) I only have two comments this time : - Indentation : We always try to indent between a block and a sub-block with *one* space : <foo> <bar> <baz /> </bar> </foo> the < of foo and /foo should be at the same position. - Safety : in udm-alloc-agent-array.xml, you talked about the dbaddr parameter of udm_alloc_agent(). Suppose that one day, someone decide to change the parameter name in udm-alloc-agent.xml (for consistency, sense, or whatever). We will then have a "buggy" link in udm-alloc-agent-array.xml So I replaced "the dbaddr parameter" by "the first parameter" ;) Nice work once again ! I've commited the ircg functions too. didou