Re: livedocs PATCH

> > > 2/ Although I want to solve the dom problem, I don't want > > to hard code dom > > > specifics into the guts of livedocs > > So how? How do you know if you to append 'dom-' to the id? > > There should be a generic mechanism to name functions based on the extension > that they are in. For, we should generate an id for ALL functions like $extension-$func_id? > > > 3/ the version stuff is not phpdoc specific; it can happily > > live in the > > > default theme. > > No! PHPDOC is the only using the version stuff. With your > > modified patch, it > > works perfectly, because you are doing: > > if ($q && LATEST_VERSION == $q) { > > This is correct. > > > and I think the correct version would be: > > if (!$q || LATEST_VERSION == $q) { > > > > because If there is no version information on the DB, it is > > considered as > > 'CVS only', so it is only avaliable in latest version. > > This is incorrect; read the comment in the source. > Not everything has version info (such as include/require) and this is showing > up incorrectly. But they could! :) Your patch has a problem. It matches only 'PHP 5?. And what about 'PHP 5.1'? You should use a substr() for example... > Can you please post one patch per issue? (I know it's a pain in the ass) OMG... OK, tomorrow or so, I'll do it. Nuno