Re: Re: [patch] livedocs : Allowing entities in titles

Mehdi Achour wrote:

Wez Furlong wrote:

Your fix looks overly magical to me, so let's backtrack:

what does the title

show in the french page?

Look here : http://didou.keliglia.com/php/phpman/fr/faq.com.html

There's a lot of section titled PHP in the menu and you'll notice that the browser title is different from the real title. Applying my patch fixes the issue and nothing seems magical to me.

The problem I have with the patch is that it doesn't seem related to this issue; particuarly when I can't replicate the effect using the english docs (livedocs code is largely language agnostic). It seems to me that the problem is elsewhere, and I'd like to identify where it is before fixing it.

Ok, so let's profile it :) livedocs/livedoc.php, line 96 : adding a var_dump($title); outputs string(3) "PHP" as you can see it here : http://didou.keliglia.com/php/phpman/fr/faq.com.html $title is returned by do_nav() do_nav() selects title from idents, when was this record inserted ? during the mktoc.php call. let's debug mktoc.php :

mkindex.php not mktoc.php