Re: 2 livedoc patches

From: Date: Mon, 23 Aug 2004 06:48:44 +0000
Subject: Re: 2 livedoc patches
References: 1  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969363425@lists.php.net to get a copy of this message
On Mon, 23 Aug 2004, Curt Zirzow wrote: > > For livedoc specific changes, i've tried to keep it as general as > possible, so other themes can easily be added/modified > appropriately. > > Patch #1: > ========= > http://zirzow.dyndns.org/patches/livedocs/navigation.patch > > livdoc_func.php: > - allows theme to define the html in navigation used for theme. > > theme/php.net/html_format.php: > - uses static.php.net for images and default css. > - top menu items point to appropriate places. > - define html for navigation items. As I wrote before, the images should be in the livedocs module so that we don't have to depend on external machines. So don't use static.php.net here. Besides that indenting is totally messed. Please make sure to use the same style of indenting for code that you add. > Patch #2 > ======== > http://zirzow.dyndns.org/patches/livedocs/css.phptheme.patch > > - attempt to fix font issues, IE still seems to be very small. > - tighten up varlistentries, as not to use so much white space. > - solid border on left nav. > - remove 600px limitation on table.table items. 1. Why did you remove my margin: 0px; from "body"? 2. We should not hard code font sizes. 3. Why did you remove all styles for a.*? and your whitespace is generally "fucked up" :) Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org

« previous php.doc (#969363425) next »