Re: #30455 [Opn]: Livedocs strips HTML comments from source

Derick, There's now about 10 patches waiting to be applied, and noone to apply them. We need to get the ball rolling on livedocs, and get it production ready sooner rather than later. Curt has done a great deal of work on the whole system, perhaps you'd be able to grant him Karma? Are there any issues about this I don't know about? Regards, Aidan <nlopess@php.net> wrote in message news:200410160711.i9G7B3cL031139@ez1.php.net... > ID: 30455 > Updated by: nlopess@php.net > Reported By: aidan@php.net > Status: Open > Bug Type: Livedocs problem > PHP Version: Irrelevant > New Comment: > > Yes, those lines can be removed safely. > > > Previous Comments: > ------------------------------------------------------------------------ > > [2004-10-16 07:02:34] aidan@php.net > > Description: > ------------ > Livedocs strips comments from files, which is a problem if you want to > add comments to HTML blocks in CDATA. > > This is the offending line: > > livedocs_funcs.php/213 > > /* strip comments */ > $data = preg_replace('@<!--\s+.*\s-->@Usm', '', $data); > > I'm not sure why this needs to be done, but perhaps it can be removed > or improved. > > > > ------------------------------------------------------------------------ > > > -- > Edit this bug report at > http://bugs.php.net/?id=30455&edit=1