Re: cvs: phpdoc /en/appendices ini.xml

I know that the skeleton creates that ext_name.global_value. Thats why the ini update script needs to skip the comments in the sources. The problem is that PDO hasn't that commented, while the others you mention have. Nuno ----- Original Message ----- From: "Richard A. Quadling" <R.Quadling@bandvulc.co.uk> To: "Nuno Lopes" <nlopess@php.net>; <phpdoc@lists.php.net> Sent: Monday, November 21, 2005 1:08 PM Subject: RE: [PHP-DOC] cvs: phpdoc /en/appendices ini.xml I think the reason is because the extension skeleton has it. Maybe some comments around these lines in the skeleton OR a little edit on the PDO code? /php-src/ext/skeleton/php_skeleton.h, line 33 -- long global_value; /php-src/ext/skeleton/skeleton.c, line 58 -- STD_PHP_INI_ENTRY("extname.global_value", "42", PHP_INI_ALL, OnUpdateLong, global_value, zend_extname_globals, extname_globals) /php-src/ext/skeleton/skeleton.c, line 69 -- extname_globals->global_value = 0; In fact, it looks like the following modules should ALL produce the same dummy ini entry ... /php-src/ext/skeleton/skeleton.c, line 58 /php-src/ext/sysvmsg/sysvmsg.c, line 107 /php-src/ext/tokenizer/tokenizer.c, line 141 /pecl/ecasound/ecasound.c, line 94 /pecl/ffi/php_ffi.c, line 73 /pecl/idn/idn.c, line 76 /pecl/paradox/paradox.c, line 208 /pecl/pdo/pdo.c, line 88 /pecl/pop3/pop3.c, line 268 /pecl/threads/threads.c, line 102 /pecl/win32std/win32std.c, line 419 /pecl/xmgrace/xmgrace.c, line 92 What is interesting is that some of these lines use OnUpdateLong and other OnUpdateInt for one of the parameters. Probably should be consistent. Got this from : http://lxr.php.net/search?string=global_value (took 123.423seconds to get to me according to FasterFox!). Richard. -----Original Message----- From: Nuno Lopes [mailto:nlopess@php.net] Sent: 18 November 2005 21:01 To: phpdoc@lists.php.net Subject: [PHP-DOC] cvs: phpdoc /en/appendices ini.xml nlopess Fri Nov 18 16:00:54 2005 EDT Modified files: /phpdoc/en/appendices ini.xml Log: I still dont know why PDO exports that dummy ini entry... http://cvs.php.net/diff.php/phpdoc/en/appendices/ini.xml?r1=1.26&r2=1.27 &ty=u Index: phpdoc/en/appendices/ini.xml diff -u phpdoc/en/appendices/ini.xml:1.26 phpdoc/en/appendices/ini.xml:1.27 --- phpdoc/en/appendices/ini.xml:1.26 Fri Nov 18 15:56:43 2005 +++ phpdoc/en/appendices/ini.xml Fri Nov 18 16:00:54 2005 @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="iso-8859-1"?> -<!-- $Revision: 1.26 $ --> +<!-- $Revision: 1.27 $ --> <appendix id="ini"> <title>&php.ini; directives</title> @@ -1632,12 +1632,6 @@

       <entry>Available since PHP 4.0.4.</entry>
      </row>
      <row>
-       <entry>pdo.global_value</entry>
-       <entry>"42"</entry>
-       <entry>PHP_INI_ALL</entry>
-       <entry>Available since PHP 5.1.0.</entry>
-      </row>
-      <row>
       <entry><link

linkend="ini.pdo-odbc.connection-pooling">pdo_odbc.connection_pooling</l ink></entry>

       <entry>"strict"</entry>
       <entry>PHP_INI_ALL</entry>