#40522 [Opn->Csd]: PATCH: reword encoding param note in mb-strrpos
| From: | dmytton@php.net | Date: | Sun, 25 Feb 2007 10:50:24 +0000 |
| Subject: | #40522 [Opn->Csd]: PATCH: reword encoding param note in mb-strrpos | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969375637@lists.php.net to get a copy of this message | ||
ID: 40522
Updated by: dmytton@php.net
Reported By: danielc at analysisandsolutions dot com
-Status: Open
+Status: Closed
Bug Type: Documentation problem
PHP Version: Irrelevant
New Comment:
I don't feel the change "back" to "backward" is necessary. If you wish
to submit a patch that rewords it differently but that is more concise
than your original patch, that'd be great.
Previous Comments:
------------------------------------------------------------------------
[2007-02-25 04:39:27] danielc at analysisandsolutions dot com
Hi David:
Please switch "back" to "backward" in the phrase "for back
compatibility".
In addition, I feel the reworded explanation that got committed is just
juggling around the old explanation. While this is clearer, it's not
crystal clear.
------------------------------------------------------------------------
[2007-02-24 21:10:08] dmytton@php.net
Your description in the patch was a little too verbose so I have
reworded it myself.
------------------------------------------------------------------------
[2007-02-17 18:16:59] danielc at analysisandsolutions dot com
Description:
------------
The note for the encoding parameter in the mb-strrpos documentation is
ambiguous to me. It can be mistakenly interpreted as meaning that the
parameter was added in 5.2 when in reality it's behavior was modified.
http://www.analysisandsolutions.com/php/mb-strrpos.encoding.explanation.diff
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=40522&edit=1