Re: Shorten subjects of PHPDOC commit emails

On 2/27/07, techtonik <techtonik@php.net> wrote:

On 2/25/07, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: On 2/25/07, techtonik <techtonik@php.net> wrote:

Why? Do these 6letters really annoy you that much?

No, but besides these 7 extra symbols there is also author name, letter date, flags and all other useful stuff that doesn't make the information fit into one line.

Why should it? The most important info are the files and the module. Even if it is important in 99% of cases (i.e. 99 files from 100) the module is obvious and those extra symbols make me constantly scroll to see what name is at the end of /en/reference/bla-bla-bla/path.xml

I prefer consistency with other modules over an edge case "useless" fix.

If there is a brand new customized loginfo.pl script (why not PHP, BTW?) - why it can't be made to display a module name only if it is different from default? For example (I do know Perl, do not beat me):

Its not written in PHP because PHP-cli didn't exist at the time... If you really really really want to make any changes to that script you are barking up the wrong tree here :]

--- loginfo_old.pl      Tue Feb 27 12:24:46 2007

+++ loginfo.pl Tue Feb 27 16:26:45 2007 @@ -224,6 +224,14 @@

         $DAYABBR[$gmtime[6]], $gmtime[3], $MONABBR[$gmtime[4]],
         $gmtime[5] + 1900, $gmtime[2], $gmtime[1], $gmtime[0]);

+my $subj_module = $module.$subj_tag; +# Skip module name in subject line if the name is default for mailing list +if ($subj_tag eq "") { + if ($module eq "phpdoc" && $#mailto eq 1 && $mailto[1] eq "phpdoc\@lists.php.net") {

+    $subj_module = "";

+ } +} + no strict; # quiet warnings after here my $email; @@ -232,7 +240,7 @@

        "To: ". join(", ", @mailto). "\n".
        $msgid.
        $rfc822date.
-       "Subject: cvs: $module$subj_tag $subj\n";
+       "Subject: cvs: $subj_module $subj\n";

my $common_body = "".

        "$cvsuser\t\t".localtime()." UTC\n".

Ok, what about making a separate list for maintaining phpdoc/ tools then?

You said earlier that it was already decided to split the lists down... make it happen :) Gimme da passwoodzzz! =) No, seriously - I just do not know what is the next thing to do - I've already mailed systems several times.

Then do it again. Short, to-the-point mail (and links to back up the decision). Heck, I read the posts you linked to before but I didn't understand the motivation nor the exact conclusion... -Hannes

-- --anatoly t.