RE: [PHP-DOC] cvs: phpdoc /en/reference/posix/functions posix-ctermid.xml posix-get-last-error.xml posix-getcwd.xml posix-getegid.xml
posix-geteuid.xml posix-getgid.xml posix-getgrgid.xml posix-getgrnam.xml posix-getgroups.xml posix-getlogin.xml posi

> -----Original Message----- > From: Hannes Magnusson [mailto:hannes.magnusson@gmail.com] > Sent: Friday, May 04, 2007 10:54 AM > To: Logan Buesching > Cc: phpdoc@lists.php.net > Subject: Re: [PHP-DOC] cvs: phpdoc /en/reference/posix/functions posix- > ctermid.xml posix-get-last-error.xml posix-getcwd.xml posix-getegid.xml posix- > geteuid.xml posix-getgid.xml posix-getgrgid.xml posix-getgrnam.xml posix- > getgroups.xml posix-getlogin.xml posi > > On 5/4/07, Nuno Lopes <nlopess@php.net> wrote: > > Hi, > > > > I did a cursory review of the commit and it's ok, except the following > > (repeated several times): > > > > + <programlisting role="php"> > > +<![CDATA[ > > +#!/usr/local/bin/php > > +<?php > > > > I don't really like the shebang there, nor I do think it should go into the > > examples. Please remove that. I can go through these and remove them sometime this weekend. I thought I had reasoning for having those, but I can't recall it now. > > The order of the <refsects /> are also weird at times. > For instance in posix_ctermid() the example is before the return > value, in posix_getegid() the notes are before the return value... > I tried to be as consistent as possible, but is there a preferred order for them? > In posix-getcwd.xml: "This function can fail on can fail on" > Must be a copy-paste error :( > BTW: The docs are already online: http://php.net/ref.posix \o/ If there are any more comments please let me know as it will help me make better docs in the future. Part of the reason why I started with the POSIX functions was that I believe they are quite less used than some other functions, and that they would be good practice grounds for when I want to work on other items. -Logan